Hi all, It builds fine on Windows.
Since there seem to be no objections, I plan to merge this PR to trunk by the end of next week. Our Linux buildbot can do the test job then. Still open is a build for macOS. Regards, Matthias Am 28.12.22 um 16:04 schrieb Matthias Seidel: > Hi all, > > I think I have all commits now in place. > > My build for Windows is still running, but if anyone could build PR #163 > for Linux/macOS that would be great! > > Regards, > > Matthias > > Am 27.12.22 um 21:23 schrieb Matthias Seidel: >> Hi Czesław, >> >> Pull Request opened: >> >> https://github.com/apache/openoffice/pull/163 >> >> This is work in progress, I still need to build it for Windows. >> >> Regards, >> >> Matthias >> >> Am 27.12.22 um 21:06 schrieb Czesław Wolański: >>> Hi Matthias, >>> >>>> On 2022/12/27 16:28:57 Matthias Seidel wrote: >>>> >>>> IMO the complete directory isn't needed anymore, the UI does not provide >>>> a way to attach a bitmap from there. >>> I tend to concur. ;‑) >>> >>> I read relevant tutorials / guides, looked deeper at the source code and >>> did some tests. >>> >>> The "Customizing OpenOffice.org" guide [1] for version 1.1 states: >>> >>>> There is no in-built tool button editor. To use a custom icon, >>>> save it to the "{installpath}/share/config/symbol" directory >>>> in *.BMP format. OOo automatically searches this directory for new icons >>>> each time the Customize Buttons dialog is opened. >>> The OOo Help provides similar information. >>> >>> It works exactly like described above. The version 1.1.5, unlike the newer >>> versions of the suite, >>> does not display the "Import" button. It allows you to reset the selected >>> icon to the default icon >>> via the "Default" button. >>> . >>> A change in the layout of the dialog probably happened in version 2.0 >>> (I failed to find any version earlier than 2.2). >>> >>> Regards, >>> Czesław >>> >>> [1] >>> https://www.openoffice.org/documentation/manuals/oooauthors/CustomizingOOo1.pdf >>> >>> >>> Am Di., 27. Dez. 2022 um 17:29 Uhr schrieb Matthias Seidel < >>> matthias.sei...@hamburg.de>: >>> >>>> Hi Czesław, >>>> >>>> Am 27.12.22 um 15:05 schrieb Czesław Wolański: >>>>> Hi all, >>>>> >>>>> While compiling the Bugzilla report about the "Change Icon" dialog, I >>>>> learned something that might shed light >>>>> on the issue Matthias raised. Nothing conclusive, of course, as I haven't >>>>> studied the source code of all versions in detail. >>>>> >>>>> ZIP archive (a .pdf file and .gif file) is available at the link given >>>>> below. >>>>> >>>>> >>>> https://drive.google.com/file/d/1WuE34KJ3ozb4jkSOH5AgouJ-wluErxgO/view?usp=share_link >>>> >>>> Thank you for your detailed information! >>>> >>>> IMO the complete directory isn't needed anymore, the UI does not provide >>>> a way to attach a bitmap from there. >>>> >>>> I plan to open a Pull Request for this. Comments welcome. >>>> >>>> Regards, >>>> >>>> Matthias >>>> >>>>> Best regards, >>>>> Czesław >>>>> >>>>> PS Thanks to Matthias for encouraging >>>>> >>>>> Am Mo., 26. Dez. 2022 um 23:16 Uhr schrieb Matthias Seidel < >>>>> matthias.sei...@hamburg.de>: >>>>> >>>>>> Hi all, >>>>>> >>>>>> what is the use of the Bitmaps in /main/extras/source/symbols? >>>>>> >>>>>> I have not seen them anywhere in AOO but we bundle them with every >>>>>> release... >>>>>> >>>>>> Regards, >>>>>> >>>>>> Matthias >>>>>> >>>>>> >>>>>>
smime.p7s
Description: S/MIME Cryptographic Signature
