Hi Carl, Am 25.09.22 um 13:37 schrieb Carl Marcum: > Hi Matthias, > > On 9/25/22 4:14 AM, Matthias Seidel wrote: >> Hi Carl, >> >> Thanks! >> >> Should we cherry-pick this at least for AOO42X? > > Now that the tests in trunk are ran standalone and independent of the > versions I haven't been back porting anything in test to AOO42X. Thanks for the clarification! So the standalone test are kept only in trunk but can be run against any branch. > > The Tab function must not have made it into 4.1.13 but it seems to be > in AOO41X since the test passed.
Yes, the function will show up in 4.1.14. Regards, Matthias > > Best regards, > Carl > >> >> Regards, >> >> Matthias >> >> Am 25.09.22 um 00:44 schrieb Carl Marcum: >>> Hi Czesław and All, >>> >>> On 8/8/22 6:23 PM, Carl Marcum wrote: >>>> Hi Czesław and All, >>>> >>>> On 8/8/22 12:23 PM, Czesław Wolański wrote: >>>>> Hi Carl, >>>>> >>>>> user-defined function "StarBasicTab" >>>>> >>>>> Function StarBasicTab(x As Long) As String >>>>> StarBasicTab = Tab(x) >>>>> End Function >>>>> >>>>> Calc does not display HT (ASCII 09) in the cell. >>>>> >>>>> Testing: >>>>> Cell A2: 1 >>>>> Cell B2: =StarBasicTab(A2) >>>>> cell C2: =REPT(UNICHAR(9);A2) >>>>> >>>>> cell D2: =(B2 = C2) >>>>> >>>>> See the .ods file available at the link >>>>> https://drive.google.com/file/d/1oh4yK6IGDdzUGwPPV7fX4J8Xr0SUlTm0/view?usp=sharing >>>>> >>>>> >>>> Perfect :) >>>> I should be able to use it just like this. >>>> I confirm it works using a trunk build. >>>> >>>> Since this was back in 2015, I think this is another example of us >>>> thinking 4.2 was right around the corner and not back-porting to 4.1. >>>> >>>> +1 to back-port it. >>>> >>>> Best regards, >>>> Carl >>>> >>>>> Hope this helps >>>>> Czesław >>>>> >>>>> >>>>> pon., 8 sie 2022 o 17:07 Matthias Seidel <matthias.sei...@hamburg.de> >>>>> napisał(a): >>>>> >>>>>> Hi Carl, >>>>>> Am 08.08.22 um 00:41 schrieb Carl Marcum: >>>>>> >>>>>> Hi Matthias, >>>>>> >>>>>> On 8/7/22 5:10 PM, Matthias Seidel wrote: >>>>>> >>>>>> Hi Carl, >>>>>> >>>>>> Am 07.08.22 um 22:36 schrieb Carl Marcum: >>>>>> >>>>>> Hi Matthias and all, >>>>>> >>>>>> On 8/7/22 10:08 AM, Matthias Seidel wrote: >>>>>> >>>>>> Hi, >>>>>> >>>>>> Damjan added the missing Tab function in 2015: >>>>>> >>>>>> https://bz.apache.org/ooo/show_bug.cgi?id=19221#c9 >>>>>> >>>>>> It was done in trunk (4.2.0) at that time. >>>>>> >>>>>> However it introduced a regression that was fixed now in trunk and >>>>>> AOO42X. >>>>>> >>>>>> @Carl: Maybe you want to add a qa test for that function? >>>>>> >>>>>> Maybe if someone could give me an small example of how it would be >>>>>> used. >>>>>> I'm assuming it is a StarBasic function and not a Calc function. >>>>>> Is that correct? >>>>>> >>>>>> Yes, StarBasic/OpenOffice Basic. >>>>>> But I am not even sure if we have tests for it? >>>>>> >>>>>> Czesław might have some code for it... >>>>>> >>>>>> I just need an small example of a method or function in Basic that >>>>>> demonstrates how one would use the Tab function and I can try to >>>>>> create a >>>>>> test for it. >>>>>> >>>>>> Help says: >>>>>> >>>>>> Print Statement [Runtime] >>>>>> >>>>>> Outputs the specified strings or numeric expressions to a dialog or >>>>>> to a >>>>>> file. >>>>>> Syntax: >>>>>> >>>>>> Print [#FileName,] Expression1[{;|,} [Spc(Number As Integer);] >>>>>> [Tab(pos As >>>>>> Integer);] [Expression2[...]] >>>>>> >>>>>> >>>>>> But I don't know if that helps. >>>>>> >>>>>> >>>>>> >>>>>> One example is the test of Clng (convert to Long) where we have a >>>>>> test >>>>>> spreadsheet [1] with a Basic macro in it like: >>>>>> >>>>>> Function StarBasicCLng(x As String) As Double >>>>>> StarBasicCLng = CLng(x) >>>>>> End Function >>>>>> >>>>>> In the spreadsheet we use this macro function in a formula like >>>>>> "=STARBASICCLNG(A2)" and test equality of the cell value with >>>>>> another cell. >>>>>> >>>>>> Then we have a unit test TestFormulaDocs.java [2] that opens these >>>>>> test >>>>>> documents and checks that the formulas worked or not. >>>>>> >>>>>> Let me know if you have any questions. >>>>>> >>>>>> [1] >>>>>> https://github.com/apache/openoffice/blob/trunk/test/testuno/data/uno/sc/fvt/StarBasicCLng.ods >>>>>> >>>>>> >>>>>> [2] >>>>>> https://github.com/apache/openoffice/blob/trunk/test/testuno/source/fvt/uno/sc/formula/TestFormulaDocs.java >>>>>> >>>>>> >>>>>> >>>>>> The question is if we want to backport that (missing) function to >>>>>> AOO41X? >>>>>> >>>>>> >>>>>> Regards, >>>>>> >>>>>> >>>>>> Matthias >>>>>> >>>>>> >>>>>> Best regards, >>>>>> Carl >>>>>> >>>>>> >>>>>> Regards, >>>>>> >>>>>> Matthias >>>>>> >>>>>> Thanks, >>>>>> Carl >>>>>> >>>>>> @All: Would it make sense to cherry-pick this for AOO41X? >>>>>> >>>>>> Regards, >>>>>> >>>>>> Matthias >>>>>> >>>>>> >>>>>> >>>>>> --------------------------------------------------------------------- >>>>>> >>>>>> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org >>>>>> For additional commands, e-mail: dev-h...@openoffice.apache.org >>>>>> >>>>>> >>>>>> >>>>>> --------------------------------------------------------------------- >>>>>> >>>>>> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org >>>>>> For additional commands, e-mail: dev-h...@openoffice.apache.org >>>>>> >>>>>> >>> The test for the star basic Tab function is in trunk [1]. >>> I ran it against trunk and AOO41X builds and it passed on both. >>> >>> Thanks Czesław for providing the test document and function. >>> >>> [1] >>> https://github.com/apache/openoffice/commit/3b297b461537a449cdc46a885832873b48e62701 >>> >>> >>> Best regards, >>> Carl >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org >>> For additional commands, e-mail: dev-h...@openoffice.apache.org >>> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org >
smime.p7s
Description: S/MIME Cryptographic Signature
