On 11/17/21 3:00 PM, Carl Marcum wrote:
Hi Arrigo,
On 11/17/21 2:43 PM, Arrigo Marchiori wrote:
Hello All,
sorry for chiming in here so late.
On Sun, Nov 14, 2021 at 10:12:05PM -0500, Carl Marcum wrote:
Hi All,
On 11/14/21 5:05 PM, Matthias Seidel wrote:
Hi Carl,
Am 14.11.21 um 22:45 schrieb Carl Marcum:
Hi Matthias,
On 11/14/21 11:44 AM, Matthias Seidel wrote:
Hi Carl,
Am 14.11.21 um 17:36 schrieb Matthias Seidel:
Hi Carl,
Am 14.11.21 um 17:31 schrieb Carl Marcum:
Hi Matthias and All,
On 11/14/21 9:10 AM, Matthias Seidel wrote:
Hi Carl,
I only have a VM available with Xubuntu 18.04.6 and AOO42X, but
have no
problems opening and saving *.STW.
Okay I'll build AOO42X and see if I have same issues as trunk.
I recompiled trunk with
--enable-crashdump=yes \
--enable-dbgutil \
and now I get a better error dialog for opening these file types:
testSaveNewSTC.stc
testSaveNewSXC.sxc
------------------
Error: uno exception caught while importing:
attempt to insert duplicate XML tag attribute: xmlns:svg
From File
<build-path-to>/openoffice/main/sc/source/filter/xml/xmlwrap.cxx
at
Line 365
Abort ? (Yes=abort / No=ignore / Cancel=core dump)
I remember that we have a commit in trunk but not in AOO42X:
https://github.com/apache/openoffice/pull/122
Until now it has not been tested... Maybe that is the problem?
I can confirm Read-Errors with AOO450 (trunk) on Windows with STW
and
SXW.
No problems with AOO420 (AOO42X).
This merge may need to be reverted...
Thanks for checking.
It might be better at this point to fix the code.
That's why I asked for testing... ;-)
I'll do some bisecting and try to narrow it down.
I am not sure if the code was ready, Arrigo might know better.
I bisected it down to this one where it starts giving me the error
which
makes sense according the the commit message:
ebd28ad3a7fedadb378ee1596803008e8c6b383b is the first bad commit
commit ebd28ad3a7fedadb378ee1596803008e8c6b383b
Raise an exception when attempting to add duplicate attributes
Yes, that's my commit. It is supposed to avoid duplicated attributes
when _saving_ files. I am surprised you see this error while _opening_
them.
I could not really understand how to reproduce this problem. Could you
please send me a RTFM or a more precise link to the
file/script/whatever?
Reverting that commit is of course possible. But it would be like
sweeping dust under the carpet. Duplicated XML attributes are just
illegal, and we should rather fix the code requesting them. IMHO, of
course.
Thank you in advance and best regards,
The test is here [1] which all these methods do you can try manually.
1. open a new writer documant.
2. type @AOO (this really doesn't matter but that's what the test does)
3. Save As "helloworld_saveas.sxw" (only extension type matters here).
4. Close and reopen it.
Repeat for the other old XML filetypes.
[1]
https://github.com/apache/openoffice/blob/trunk/test/testgui/source/bvt/gui/FileTypeTest.java
In the meantime I'll build trunk again and make sure I'm getting the
save results.
Yes, I just built trunk again (c2aa676) looks like I'm two typo commits
behind.
And I still get the errors.
These errors are upon opening a newly created file with trunk.
To test an existing file I just created a SXW file with 4.1.11 and moved
it to my test VM.
My build of AOO42X will open it and my trunk build has a read error so
it's not in the writing of the file from what I can tell from that test.
Thanks,
Carl
Thanks,
Carl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org
