ardovm commented on pull request #139: URL: https://github.com/apache/openoffice/pull/139#issuecomment-934728666
Looks good to me, because the string is not translated. We could argue that translating this and other strings returned by `getServiceDisplayName(const Locale&)` methods would be a good idea: the `Locale` parameter is there for a reason... but IMHO it is not the purpose of this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
