leginee commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r568215534
##########
File path: main/sw/inc/shellio.hxx
##########
@@ -414,18 +410,18 @@ SW_DLLPUBLIC SwRead SwGetReaderXML();
// END source/filter/basflt/fltini.cxx
-extern sal_Bool SetHTMLTemplate( SwDoc &rDoc ); //Fuer Vorlagen aus HTML.vor
laden shellio.cxx
+extern sal_Bool SetHTMLTemplate( SwDoc &rDoc ); // HTML templates (pre?)load
shellio.cxx
Review comment:
I slowly get the Idea that the comment is borked. I checked opengrok and
I found the line:
bHTMLTemplSet = SetHTMLTemplate( *GetDoc() );//Styles aus HTML.vor in
InitNew() (see docshini.cxx 127)
I assume from the code that it should mean:
Extract HTMLTemplates from given Document.
But when I check docsh2.cxx 1720 :
// fix #51032#: Die HTML-Vorlage muss noch gesetzt werden
SetHTMLTemplate( *GetDoc() ); //Styles aus HTML.vor
The fix comment translates to: The HTML-Template has to be set
The next line says Syles from HTML.vor maybe that is a fixed term?
##########
File path: main/sw/inc/shellio.hxx
##########
@@ -414,18 +410,18 @@ SW_DLLPUBLIC SwRead SwGetReaderXML();
// END source/filter/basflt/fltini.cxx
-extern sal_Bool SetHTMLTemplate( SwDoc &rDoc ); //Fuer Vorlagen aus HTML.vor
laden shellio.cxx
+extern sal_Bool SetHTMLTemplate( SwDoc &rDoc ); // HTML templates (pre?)load
shellio.cxx
Review comment:
Great. Checking the Issue is leading to a wrong issue. Probably the
Number is to old to be recognized?
##########
File path: main/sw/inc/shellio.hxx
##########
@@ -367,32 +363,32 @@ public:
void SetBaseURL( const String& rURL );
sal_Bool IsOld() const;
- sal_uLong ConvertToNew(); //
Textbausteine konvertieren
+ sal_uLong ConvertToNew(); // convert
AutoText entries (ger: Textbausteine)
- sal_uInt16 GetCount() const;
// Anzahl Textbausteine ermitteln
- sal_uInt16 GetIndex( const String& ) const; //
Index fuer Kurznamen ermitteln
+ sal_uInt16 GetCount() const;
// return amount of AutoText entries
+ sal_uInt16 GetIndex( const String& ) const; //
return Index of shortnames
sal_uInt16 GetLongIndex( const String& ) const; //Index fuer
Langnamen ermitteln
Review comment:
Watzlav has pointed this out, too. I have to work his comments in. Did
not have the time. At the end of the week I think I can put again some more
time.
##########
File path: main/sw/inc/shellio.hxx
##########
@@ -367,32 +363,32 @@ public:
void SetBaseURL( const String& rURL );
sal_Bool IsOld() const;
- sal_uLong ConvertToNew(); //
Textbausteine konvertieren
+ sal_uLong ConvertToNew(); // convert
AutoText entries (ger: Textbausteine)
- sal_uInt16 GetCount() const;
// Anzahl Textbausteine ermitteln
- sal_uInt16 GetIndex( const String& ) const; //
Index fuer Kurznamen ermitteln
+ sal_uInt16 GetCount() const;
// return amount of AutoText entries
+ sal_uInt16 GetIndex( const String& ) const; //
return Index of shortnames
sal_uInt16 GetLongIndex( const String& ) const; //Index fuer
Langnamen ermitteln
Review comment:
Czesław has pointed this out, too. I have to work his comments in. Did
not have the time. At the end of the week I think I can put again some more
time.
[Edit:] sry got the name wrong. I am not awake... :(
##########
File path: main/sw/inc/shellio.hxx
##########
@@ -414,18 +410,18 @@ SW_DLLPUBLIC SwRead SwGetReaderXML();
// END source/filter/basflt/fltini.cxx
-extern sal_Bool SetHTMLTemplate( SwDoc &rDoc ); //Fuer Vorlagen aus HTML.vor
laden shellio.cxx
+extern sal_Bool SetHTMLTemplate( SwDoc &rDoc ); // HTML templates (pre?)load
shellio.cxx
Review comment:
"Load template from HTML template shellio.cxx" ? Does not make sense to
me. :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org
