Grosskopf commented on pull request #112: URL: https://github.com/apache/openoffice/pull/112#issuecomment-746000980
> If not needed I would would opt that the dead code is removed. :) Can you remove it? or should I check how I can incorporate this wish? I think I did remove it, is it not gone? this commit history is messy... > We need only the Apache License. If I were you I would add the License to the Comments that the patch is under dual License (Apache License, Mozilla License). But this is me. should I do this in the code? in the conversations around the patches I mentioned this... Also I just found bugs I propably did in this patch... I tested another report without repeating groupheaders and it's not working anymore, not sure why... so this shouldn't be merged as of now... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
