fixed: it was a strcpy overflow.

> On Dec 2, 2020, at 9:02 PM, Damjan Jovanovic <dam...@apache.org> wrote:
> 
> That's in main/soltools.
> 
> Try isolate the exact command used, and try run that problematic
> makedeepend binary in a debugger with the same args. 4 = SIGILL, a bad
> sign, possibly a buffer overflow because the absolute filesystem path to
> AOO is too long, or other such.
> 
> On Wed, Dec 2, 2020 at 9:31 PM Jim Jagielski <j...@jagunet.com 
> <mailto:j...@jagunet.com>> wrote:
> 
>> Building --enable-debug is causing a weird issue...
>> 
>> ../unxmaccx.pro/bin/makedepend: error:  got signal 4
>> dmake:  Error code 1, while making '../unxmaccx.pro/obj/checkdll.obj'
>> dmake:  '../unxmaccx.pro/obj/checkdll.obj' removed.
>> 
>> I'm not sure if this is macOS specific or whether or not doing so breaks
>> on other platforms as well... anyone know before I spin up another VM and
>> test?
>> 
>>> On Dec 2, 2020, at 10:25 AM, Damjan Jovanovic <dam...@apache.org> wrote:
>>> 
>>> On Wed, Dec 2, 2020 at 3:35 PM Jim Jagielski <j...@jagunet.com 
>>> <mailto:j...@jagunet.com> <mailto:
>> j...@jagunet.com>> wrote:
>>> 
>>>> So I've been working on some of the macOS bugz and am looking at the UNO
>>>> bridge as a likely subject, hence the various changes to the macOS code
>>>> there. I'm hoping someone can help me with this crash.
>>>> 
>>>> I open up Extension Manager, hit check for updates and AOO immediately
>>>> dies, with the following bt. Any ideas?
>>>> 
>>>> Thread 5 Crashed:
>>>> 0   libobjc.A.dylib                     0x00007fff6d7c381d objc_msgSend
>> +
>>>> 29
>>>> 1   libvcl.dylib                        0x00000001046a400f
>>>> 
>> DragSource::initialize(com::sun::star::uno::Sequence<com::sun::star::uno::Any>
>>>> const&) + 175
>>>> 2   libuno_cppuhelpers5abi.dylib        0x000000010308b1a0
>>>> 
>> cppu::OSingleFactoryHelper::createInstanceWithArgumentsAndContext(com::sun::star::uno::Sequence<com::sun::star::uno::Any>
>>>> const&,
>>>> com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>
>>>> const&) + 128
>>>> 3   libuno_cppuhelpers5abi.dylib        0x000000010308bffd
>>>> 
>> cppu::OFactoryComponentHelper::createInstanceWithArgumentsAndContext(com::sun::star::uno::Sequence<com::sun::star::uno::Any>
>>>> const&,
>>>> com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>
>>>> const&) + 77
>>>> 4   libuno_cppuhelpers5abi.dylib        0x000000010308c102 non-virtual
>>>> thunk to
>>>> 
>> cppu::OFactoryComponentHelper::createInstanceWithArgumentsAndContext(com::sun::star::uno::Sequence<com::sun::star::uno::Any>
>>>> const&,
>>>> com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>
>>>> const&) + 18
>>>> 5   libuno_cppuhelpers5abi.dylib        0x000000010308da68
>>>> 
>> cppu::ORegistryFactoryHelper::createInstanceWithArgumentsAndContext(com::sun::star::uno::Sequence<com::sun::star::uno::Any>
>>>> const&,
>>>> com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>
>>>> const&) + 56
>>>> 6   libuno_cppuhelpers5abi.dylib        0x000000010308dc62 non-virtual
>>>> thunk to
>>>> 
>> cppu::ORegistryFactoryHelper::createInstanceWithArgumentsAndContext(com::sun::star::uno::Sequence<com::sun::star::uno::Any>
>>>> const&,
>>>> com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>
>>>> const&) + 18
>>>> 7   bootstrap.uno.dylib                 0x000000010b9e7c8c
>>>> 
>> stoc_smgr::OServiceManager::createInstanceWithArgumentsAndContext(rtl::OUString
>>>> const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&,
>>>> com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>
>>>> const&) + 236
>>>> 8   bootstrap.uno.dylib                 0x000000010b9e807f non-virtual
>>>> thunk to
>>>> stoc_smgr::OServiceManager::createInstanceWithArguments(rtl::OUString
>>>> const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)
>> + 31
>>>> 9   libvcl.dylib                        0x000000010495b4fd
>>>> Window::GetDragSource() + 813
>>>> 10  libvcl.dylib                        0x000000010495adf4
>>>> Window::GetDropTarget() + 84
>>>> 11  libsvt.dylib                        0x0000000103adb2cf
>>>> DropTargetHelper::DropTargetHelper(Window*) + 63
>>>> 12  libsvt.dylib                        0x0000000103992f2b
>>>> SvLBox::SvLBox(Window*, ResId const&) + 139
>>>> 13  libsvt.dylib                        0x000000010399b6f9
>>>> SvTreeListBox::SvTreeListBox(Window*, ResId const&) + 25
>>>> 14  libsvxcore.dylib                    0x00000001052392d5
>>>> SvxCheckListBox::SvxCheckListBox(Window*, ResId const&, Image const&,
>> Image
>>>> const&) + 21
>>>> 15  libdeploymentgui.uno.dylib          0x000000010320672a
>>>> dp_gui::UpdateDialog::CheckListBox::CheckListBox(dp_gui::UpdateDialog&,
>>>> ResId const&, Image const&, Image const&) + 26
>>>> 16  libdeploymentgui.uno.dylib          0x00000001032035f5
>>>> 
>> dp_gui::UpdateDialog::UpdateDialog(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>
>>>> const&, Window*,
>>>> 
>> std::__1::vector<com::sun::star::uno::Reference<com::sun::star::deployment::XPackage>,
>>>> 
>> std::__1::allocator<com::sun::star::uno::Reference<com::sun::star::deployment::XPackage>
>>>>>> const&, std::__1::vector<dp_gui::UpdateData,
>>>> std::__1::allocator<dp_gui::UpdateData> >*) + 565
>>>> 17  libdeploymentgui.uno.dylib          0x0000000103215991
>>>> 
>> dp_gui::ExtensionCmdQueue::Thread::_checkForUpdates(std::__1::vector<com::sun::star::uno::Reference<com::sun::star::deployment::XPackage>,
>>>> 
>> std::__1::allocator<com::sun::star::uno::Reference<com::sun::star::deployment::XPackage>
>>>>>> const&) + 113
>>>> 18  libdeploymentgui.uno.dylib          0x00000001032145da
>>>> dp_gui::ExtensionCmdQueue::Thread::execute() + 906
>>>> 19  libdeploymentgui.uno.dylib          0x00000001031fffa7 non-virtual
>>>> thunk to dp_gui::Thread::run() + 23
>>>> 20  libsofficeapp.dylib                 0x0000000102e4ee9f threadFunc +
>> 15
>>>> 21  libuno_sal.dylib                    0x0000000102c22cf9 0x102c1b000 +
>>>> 31993
>>>> 22  libsystem_pthread.dylib             0x00007fff6eb7d109
>> _pthread_start
>>>> + 148
>>>> 23  libsystem_pthread.dylib             0x00007fff6eb78b8b thread_start
>> +
>>>> 15
>>>> 
>>>> 
>>>> 
>>> Looks like the update dialog contains a "treelistbox" which attempts to
>>> initialize drag-and-drop, and DragSource::initialize() in frame 1 then
>> does
>>> something to cause the crash.
>>> 
>>> Can you drag-and-drop within AOO generally, eg. drag a file from your
>> file
>>> manager into Writer?
>>> 
>>> The code seems to be in
>>> 
>> http://opengrok.openoffice.org/xref/trunk/main/vcl/aqua/source/dtrans/DragSource.cxx?r=9f62ea84#183
>>  
>> <http://opengrok.openoffice.org/xref/trunk/main/vcl/aqua/source/dtrans/DragSource.cxx?r=9f62ea84#183>
>> <
>> http://opengrok.openoffice.org/xref/trunk/main/vcl/aqua/source/dtrans/DragSource.cxx?r=9f62ea84#183
>>  
>> <http://opengrok.openoffice.org/xref/trunk/main/vcl/aqua/source/dtrans/DragSource.cxx?r=9f62ea84#183>
>>> 
>>> 
>>> Make a debug build (which should have line numbers), and show us the
>> stack
>>> trace from that?
>>> 
>>> Alternatively, if you know a recent version in which the update dialog
>>> didn't crash, "git bisect" to find the offending commit.
>>> 
>>> Damjan

Reply via email to