pedlino commented on pull request #89: URL: https://github.com/apache/openoffice/pull/89#issuecomment-695216940
> > A good test is after apply that the Font still works as expected. The patch first was a quick and dirty fix, and this should be the proper one. > > Are there any automated tests about the proper rendering of fonts? Like a comparison with a pre-rasterized sample? > > I could prepare a very simple ODT with English and Chinese characters, but it would require human evaluation. > Something like: > > > This character is an horizontal line: 一 > > This character is two horizontal lines: 二 > > This character looks like a tall rectangle with an horizontal line in the middle: 日 > > Here are letters "aeiou" with grave accents: àèìòù > > Having the above in the Noto Sans CJK font would ensure that English, European and Chinese characters are all rendered correctly (the first three characters were copied and pasted from Chinese text). > > I am feeling a bit stupid while typing this, like I am reinventing the wheel using the wrong tools, but please understand I am only trying to help. Never feel stupid for trying to help! If the wheel was already invented but you can't find it, it is certainly not your fault ;) Such an ODT would help. I think the description is not necessary. What is needed is a screenshot before and after the patch is applied. If visually there is no loss of characters or loss of quality of rendering then the patch can be accepted. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
