If it is not used we should drop the code. I do not believe anyone will use
this part.
The whole file is only used to calculate Grescale palette and some other
predifened bitmap. The object created I think behind all this is bitmap device
(or similar) which I think should be replaced at some point.
Am 6. November 2019 00:48:34 MEZ schrieb Don Lewis <truck...@apache.org>:
>On 5 Nov, Peter Kovacs wrote:
>> I am not sure why, but if you use gcc++98 std it compiles. Maybe it
>> optimizes the code since it might be dead code.
>
>It breaks the build in any mode for me with gcc9. I vaguely remember
>running across this code before, maybe with clang after it's default
>language version changed and before I changed the FreeBSD port to
>gnu++89.
>
>It does seem to be unused. I can comment out the entire method and the
>build still succeeds.
>
>I'll probably commit that along with a note. If someone needs this
>method in the future, they can presumably figure out what the correct
>fix is.
>
>> I rewrote the whole code, and used one class instead of 4 macros that
>> copy paste from each other. I can post the code.
>>
>> But I do not know how to test or apply it into the rest. :P
>>
>>
>> On 05.11.19 19:54, Don Lewis wrote:
>>> I don't understand what this strange little bit of code (line 611 of
>>> basebmp/inc/basebmp/packedpixeliterator.hxx) is supposed to do:
>>>
>>> value_type get(difference_type const & d) const
>>> {
>>> const int remainder( x(d.x) % num_intraword_positions );
>>> ^^^^^^
>>> return (unsigned_cast<value_type>(*current(d.x,d.y) &
>>> get_mask<value_type,
>bits_per_pixel, MsbFirst>(remainder))
>>> >> get_shift<num_intraword_positions,
>bits_per_pixel, MsbFirst>(remainder));
>>> }
>>>
>>> I've never seen any compiler complaints about it before, but gcc 9
>>> throws an error:
>>>
>>> ../inc/basebmp/packedpixeliterator.hxx: In member function
>'basebmp::PackedPixel
>>> Iterator<Valuetype, bits_per_pixel, MsbFirst>::value_type
>basebmp::PackedPixelIt
>>> erator<Valuetype, bits_per_pixel, MsbFirst>::get(const
>difference_type&) const':
>>> ../inc/basebmp/packedpixeliterator.hxx:611:35: error: expression
>cannot be used
>>> as a function
>>> 611 | const int remainder( x(d.x) %
>num_intraword_positions );
>>> | ^
>>>
>>>
>>>
>---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
>>> For additional commands, e-mail: dev-h...@openoffice.apache.org
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
>> For additional commands, e-mail: dev-h...@openoffice.apache.org
>>
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
>For additional commands, e-mail: dev-h...@openoffice.apache.org
