On Mon, Mar 5, 2018 at 3:29 PM, Patricia Shanahan <p...@acm.org> wrote:
> > > On 3/4/2018 11:27 PM, Damjan Jovanovic wrote: > ... > >> But there is a simple way to both keep the 64->32 bit building working >> while making the 64 bit changes in trunk, and still get the benefits of >> testing. The changes involved to enable the 64 bit build environment >> amount >> to 1 relatively small patch affecting only 5 files, and without this patch >> it will still build 32 bit binaries on 64 bit Windows. Thus this patch can >> be maintained out-of-tree while patching modules to build on Win64, and >> those building without this patch will end up automatically testing >> whether >> any of the (small and relatively safe) module changes broke the Win32 >> build. >> > ... > > In general, I favor keeping things checked in, but in keep the patch that > breaks 64->32 in its own branch. The remaining changes can go in the trunk. > > The patch affects 4 files and is only 254 lines long in total, so I've just placed it into main/solenv/win64/win64.patch together with a readme file referring people to the wiki page ( https://wiki.openoffice.org/wiki/Win64_port) where I've described how to apply it and start the Win64 build.
