Am 08/03/2016 04:48 AM, schrieb Dennis E. Hamilton:
Please vote by reply to this dev@-list thread on the approval of the candidate
for release.
[ ] +1 Approve, with description
[ ] 0 Abstain
[ ] -1 Disapprove, with explanation
+1 Approve
For +1 Approve votes, please describe the results of verifying the patch
materials and success in building a 4.1.2 binary having the patch applied to a
particular 4.1.2 binary build.
1. I've verified the hashes:
$ md5sum -c apache-openoffice-4.1.2-patch1.zip.md5
--> OK (but only without the line break)
$ sha256sum -c apache-openoffice-4.1.2-patch1.zip.sha256
--> OK (but only without the line break)
$ gpg --verify apache-openoffice-4.1.2-patch1.zip.asc
apache-openoffice-4.1.2-patch1.zip
--> ...
gpg: Good signature from "keybase.io/orcmid (confirmed identifier)
<orc...@keybase.io>"
...
2. As for the source code, I've checked out the fix from the code base
in SVN and compared it with the zipped patch.
2a. Compared patched "poly2.cxx" with SVN revision previous to the patch:
$ svn co
https://svn.apache.org/repos/asf/openoffice/trunk/main/tools/source/generic/
/home/marcus/aoo
$ svn diff -c 1753426 /home/marcus/aoo/poly2.cxx
Index: poly2.cxx
===================================================================
--- poly2.cxx (revision 1753425)
+++ poly2.cxx (revision 1753426)
@@ -198,6 +198,7 @@
{
DBG_CHKTHIS( PolyPolygon, NULL );
DBG_ASSERT( nPos < Count(), "PolyPolygon::Remove(): nPos >= nSize" );
+ if ( nPos >= Count() ) return; // not removable
if ( mpImplPolyPolygon->mnRefCount > 1 )
{
@@ -218,6 +219,7 @@
{
DBG_CHKTHIS( PolyPolygon, NULL );
DBG_ASSERT( nPos < Count(), "PolyPolygon::Replace(): nPos >= nSize" );
+ if ( nPos >= Count() ) return; // not replaceable
if ( mpImplPolyPolygon->mnRefCount > 1 )
{
--> OK, only the patched lines are the difference.
2b. Compared patched "poly2.cxx" with SVN current revision:
$ svn co
https://svn.apache.org/repos/asf/openoffice/trunk/main/tools/source/generic/
/home/marcus/aoo
$ diff
/home/marcus/patch/source/apache-openoffice-4.1.2-patch1/poly2.cxx
/home/marcus/aoo/poly2.cxx
--> OK, many diffs but only due to white spaces.
Marcus
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org
