Hi Patricia, with that patch, you were going in the right direction by moving the declaration of OSQLParser_Data to the publicly visible inc/connectivity/sqlparse.hxx, but since that header doesn't (and shouldn't?) have "using namespace ::com::sun::star::...", this needed changing:
- ::connectivity::OSQLParser_Data( const Reference< XMultiServiceFactory >& _xServiceFactory ); + ::connectivity::OSQLParser_Data( const ::com::sun::star::uno::Reference< ::com::sun::star::lang::XMultiServiceFactory >& _xServiceFactory ); and sqlparse.cxx needed to have the declaration removed while leaving the constructor's definition. I've committed your patch in #1747439 with you as the author, then committed my fixes to it in #1747440. You did most of the work, so thank you! Damjan On Wed, May 11, 2016 at 12:08 AM, Patricia Shanahan <p...@acm.org> wrote: > I decided to try to fix the underlying error/warning, by making the header > file declaration complete. Unfortunately, I think my C++ rustiness is > getting in the way. I get an error suggesting a constructor is being > treated as a function. > > I've attached a diff in the hope that someone else can fix my attempt. > > > On 4/30/2016 2:01 AM, Oliver Brinzing wrote: > >> >> My previous, successful, debug compile was revision 1734822, March >>> >> 13th 2016, so the problem has to >> >>> be something that has changed since then. >>> >> >> i checked output from pro an debug build: >> >> debug creates an error C4150 while pro will continue with a warning >> >> the different compiler setting are: >> >> pro -Gy -Oxs -Oy- -DPRODUCT -DNDEBUG -DOSL_DEBUG_LEVEL=0 -DOPTIMIZE >> >> dbg -Zi -Od -Z7 -Yd -D_STLP_DEBUG -DDEBUG -DDBG_UTIL >> -DOSL_DEBUG_LEVEL=2 >> -Fd../../wntmsci12/misc/sqliterator.pdb >> >> Oliver >> >> >> ------------------------------------------------------------------------------------------------ >> >> debug: >> Compiling: connectivity/source/parse/sqliterator.cxx >> C:/PROGRA~2/MICROS~1.0/VC/bin/cl.exe -Zm500 -Zc:wchar_t- -GR -GS -c >> -nologo -Gs -Ob1 -Zi -Fd../../wntmsci12/misc/sqliterator.pdb -Od >> -DENABLE_LAYOUT=0 -DENABLE_LAYOUT_EXPERIMENTAL=0 -Gd -I. >> -I../../wntmsci12/misc -I../../wntmsci12/inc/sql -I../inc >> -I../../inc/pch -I../../inc -I../../WIN/inc -I../../wntmsci12/inc -I. >> -IC:/build_tmp/trunk/main/solver/420/wntmsci12/inc/stl >> -IC:/build_tmp/trunk/main/solver/420/wntmsci12/inc/external >> -IC:/build_tmp/trunk/main/solver/420/wntmsci12/inc >> -IC:/build_tmp/trunk/main/solenv/wntmsci12/inc >> -IC:/build_tmp/trunk/main/solenv/inc -IC:/build_tmp/trunk/main/res >> -IC:/build_tmp/trunk/main/tools/inc >> -IC:/build_tmp/trunk/main/comphelper/inc >> -IC:/PROGRA~2/Java/JDK17~1.0/include/win32 >> -IC:/PROGRA~2/Java/JDK17~1.0/include >> -IC:/PROGRA~1/MICROS~1/Windows/v7.0/include >> -IC:/PROGRA~2/MICROS~1.0/VC/include -IC:/PROGRA~2/MICROS~1/include >> -IC:/PROGRA~2/MICROS~1/include >> -IC:/build_tmp/trunk/main/solver/420/wntmsci12/inc/offuh -I. -I../../res >> -I. -Z7 -Yd -Wall -wd4061 -wd4127 -wd4191 -wd4217 -wd4250 -wd4251 >> -wd4275 -wd4290 -wd4294 -wd4355 -wd4511 -wd4512 -wd4514 -wd4611 >> -wd4625 -wd4626 -wd4640 -wd4675 -wd4710 -wd4711 -wd4786 -wd4800 >> -wd4820 -wd4503 -wd4619 -wd4365 -wd4668 -wd4738 -wd4826 -wd4350 >> -wd4505 -wd4692 -wd4189 -wd4005 -wd4180 -DWNT -DWNT -DNT351 -DMSC >> -DM1500 -DINTEL -D_STLP_DEBUG -D_X86_=1 -D_CRT_SECURE_NO_DEPRECATE >> -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NON_CONFORMING_SWPRINTFS -DFULL_DESK >> -DBOOST_MEM_FN_ENABLE_CDECL -D_MT -DWINVER=0x0500 -D_WIN32_WINNT=0x0500 >> -D_WIN32_IE=0x0500 -DCPPU_ENV=msci -DSUPD=420 -DDEBUG -DDBG_UTIL >> -DOSL_DEBUG_LEVEL=2 -DCUI -DSOLAR_JAVA -DOOO_DLLIMPLEMENTATION_DBTOOLS >> -DSHAREDLIB -D_DLL_ -DWIN32 -D_MT -D_DLL -DWIN32 -D_MT -D_DLL -EHa >> -DEXCEPTIONS_ON -Fo../../wntmsci12/slo/sqliterator.obj >> C:/build_tmp/trunk/main/connectivity/source/parse/sqliterator.cxx >> sqliterator.cxx >> C:\PROGRA~2\MICROS~1.0\VC\include\memory(721) : error C4150: deletion of >> pointer to incomplete type 'connectivity::OSQLParser_Data'; no >> destructor called >> >> >> ------------------------------------------------------------------------------------------------ >> >> pro: >> Compiling: connectivity/source/parse/sqliterator.cxx >> C:/PROGRA~2/MICROS~1.0/VC/bin/cl.exe -Zm500 -Zc:wchar_t- -GR -GS -c >> -nologo -Gs -Gy -Ob1 -Oxs -Oy- -DENABLE_LAYOUT=0 >> -DENABLE_LAYOUT_EXPERIMENTAL=0 -Gd -I. -I../../wntmsci12.pro/misc >> -I../../wntmsci12.pro/inc/sql -I../inc -I../../inc/pch -I../../inc >> -I../../WIN/inc -I../../wntmsci12.pro/inc -I. >> -IC:/build_tmp/trunk/main/solver/420/wntmsci12.pro/inc/stl >> -IC:/build_tmp/trunk/main/solver/420/wntmsci12.pro/inc/external >> -IC:/build_tmp/trunk/main/solver/420/wntmsci12.pro/inc >> -IC:/build_tmp/trunk/main/solenv/wntmsci12/inc >> -IC:/build_tmp/trunk/main/solenv/inc -IC:/build_tmp/trunk/main/res >> -IC:/build_tmp/trunk/main/tools/inc >> -IC:/build_tmp/trunk/main/comphelper/inc >> -IC:/PROGRA~2/Java/JDK17~1.0/include/win32 >> -IC:/PROGRA~2/Java/JDK17~1.0/include >> -IC:/PROGRA~1/MICROS~1/Windows/v7.0/include >> -IC:/PROGRA~2/MICROS~1.0/VC/include -IC:/PROGRA~2/MICROS~1/include >> -IC:/PROGRA~2/MICROS~1/include >> -IC:/build_tmp/trunk/main/solver/420/wntmsci12.pro/inc/offuh -I. >> -I../../res -I. -Wall -wd4061 -wd4127 -wd4191 -wd4217 -wd4250 -wd4251 >> -wd4275 -wd4290 -wd4294 -wd4355 -wd4511 -wd4512 -wd4514 -wd4611 >> -wd4625 -wd4626 -wd4640 -wd4675 -wd4710 -wd4711 -wd4786 -wd4800 >> -wd4820 -wd4503 -wd4619 -wd4365 -wd4668 -wd4738 -wd4826 -wd4350 >> -wd4505 -wd4692 -wd4189 -wd4005 -wd4180 -DWNT -DWNT -DNT351 -DMSC >> -DM1500 -DINTEL -D_X86_=1 -D_CRT_SECURE_NO_DEPRECATE >> -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NON_CONFORMING_SWPRINTFS -DFULL_DESK >> -DBOOST_MEM_FN_ENABLE_CDECL -D_MT -DWINVER=0x0500 -D_WIN32_WINNT=0x0500 >> -D_WIN32_IE=0x0500 -DCPPU_ENV=msci -DSUPD=420 -DPRODUCT -DNDEBUG >> -DOSL_DEBUG_LEVEL=0 -DOPTIMIZE -DCUI -DSOLAR_JAVA >> -DOOO_DLLIMPLEMENTATION_DBTOOLS -DSHAREDLIB -D_DLL_ -DWIN32 -D_MT -D_DLL >> -DWIN32 -D_MT -D_DLL -EHa -DEXCEPTIONS_ON >> -Fo../../wntmsci12.pro/slo/sqliterator.obj >> C:/build_tmp/trunk/main/connectivity/source/parse/sqliterator.cxx >> sqliterator.cxx >> C:/PROGRA~2/MICROS~1.0/VC/include\memory(721) : warning C4150: deletion >> of pointer to incomplete type 'connectivity::OSQLParser_Data'; no >> destructor called >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org >> For additional commands, e-mail: dev-h...@openoffice.apache.org >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org >
