Great work! Considering the nature of the issue, where users have important files they can no longer open, I would think getting it into an early maintenance release (e.g., a 4.1.3) along with many other fixes that don't impact UI, localization, documentation, etc., would be a preferable solution.
This does not seem to be the kind of problem to hold back to a feature release. - Dennis > -----Original Message----- > From: Damjan Jovanovic [mailto:dam...@apache.org] > Sent: Saturday, January 16, 2016 05:26 > To: Apache OO <dev@openoffice.apache.org> > Subject: Re: Remove NSS from xmlsecurity - alternatives? > [ ... ] > Which I did in r1724971: > > #i125431# "The Password is incorrect. The file cannot be opened." > > Fix a serious cross-platform regression caused during SeaMonkey's > removal > and first released in version 4.1.0, where all features provided by NSS > (like opening and saving encrypted documents, digital signatures, etc.) > were failing. > > SYSTEM_MOZILLA doesn't exist any more, yet was being used to check > whether > to skip loading nssckbi when SECMOD_HasRootCerts() is true, so we were > always attempting to load it even when not necessary. Also with > SYSTEM_MOZILLA skipping loading it from the system path, we were > always trying to load it from "${OOO_BASE_DIR}/program/libnssckbi.so" > even when it wasn't there because --with-system-nss was passed to > ./configure. > > This patch fixes the above problems by using SYSTEM_NSS instead of > SYSTEM_MOZILLA, which actually exists, now both skipping loading > nssckbi when unnecessary, and loading it from the right place > when necessary. > > Now let's release that to our users in 4.2.0 soon? > > Regards > Damjan --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
