Kay Schenk wrote:
​Ok, these are comments that already existed but I will change the
spelling...

Yes, all fixes are not due to some mistakes in your work, but to previous stuff.

but the corresponding fixes still need to be done on the 4.1.0 -> 4.1.2
feed (and probably to the other two too) as currently attached to the issue.
​I'm not quite understanding this last comment. Please see the update feed
already committed you refer to.​

The committed one is 4.1.1 -> 4.1.2 and it is correct. The broken one is 4.1.0 -> 4.1.2 and you fixed it with the spelling correction but not with the localized sites update. The latest one https://bz.apache.org/ooo/attachment.cgi?id=85105 still misses the Lithuanian site (it doesn't contain "/lt").

​The native lang urls are not directly referenced in the update feed.

Yes they are. If I am using version 4.1.1 in Italian, the pop-up will send me to
http://www.openoffice.org/it/download/
and not to
http://www.openoffice.org/download/
since line 1342 (and similar) of http://svn.apache.org/viewvc/openoffice/updates-site/trunk/aoo411/check.Update?view=markup are configured that way. So the two "missing" languages were not missing, but they were sending people to a wrong (well, a working one but not the best one) URL.

​ah! I actually found a generation script for this at:
http://svn.apache.org/viewvc/openoffice/devtools/genUpdateFeed/

Good find! You really saved us a lot of time by investigating, thanks. This is perfect to the purpose, and even the list I had in mind is already done there:

http://svn.apache.org/viewvc/openoffice/devtools/genUpdateFeed/LanguageCodeMap.txt?revision=1619063&view=markup

So a fix on lines 36 and 40 of that file will incorporate the 3 fixes (Lithuanian spelling, Lithuanian URL, Portuguese URL) and it will be enough to:
1) Regenerate all 4.x.y -> 4.1.2 feeds with it
2) Compare the generated feed for 4.1.1 -> 4.1.2 to the one you committed, so that we can check it is consistent.

How we lost the two languages initially I don't know.

We never lost them. What happened is that in 2014 we didn't have a well-maintained Lithuanian and Portuguese site. We now do, so the best target URL for updates from Lithuanian and Portuguese has now changed. And this is why we have a file (link above) for it.

Regards,
  Andrea.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

Reply via email to