On 18 July 2015 at 00:00, Andrea Pescetti <pesce...@apache.org> wrote:
> On 16/07/2015 bugzilla wrote: > >> Kay has asked for 4.1.2_release_blocker: >> Issue 126401: Add ASF license headers to files >> https://bz.apache.org/ooo/show_bug.cgi?id=126401 >> > > Unless I'm really mistaken this does not apply to AOO410: those files do > not exist in AOO410, as I wrote yesterday. But Kay is the third person > mentioning this issue after Jan and Marcus, so if I am the one who is wrong > just show me the path on AOO410 where the patch should be applied and I'll > definitely take a look. > > What I see is: > https://svn.apache.org/viewvc/openoffice/trunk/main/ > contains an "ooxml" directory with the problematic files; > https://svn.apache.org/viewvc/openoffice/branches/AOO410/main/ > does not contain that subdirectory at all, so it does not contain the > problem. > > Well, fortunately we now have a buildbot that performs a nightly RAT scan > on AOO410 at https://ci.apache.org/builders/openoffice-linux64-rat-aoo410/ > so (after some initial setup issues are fixed: they are responsible for the > failures you see) we will all have the RAT output visible on the web and we > will agree! > > If RAT scan passes on AOO410, then the patch does not need porting to > AOO410 and can't be a blocker for 4.1.2. Any problems found by RAT on > AOO410 are, instead, blockers for 4.1.2 and need to be reported and > nominated. I'll wait for a RAT output that we can all see and agree upon > before commenting in the issue. > I am lost in all these branches and tags, but I have one position, we run rat scan on the release candidate and any problems is the same as a no-go for release. If rat-scan is clean, whether or not these files are includes I am happy and so it the legal side of apache. rgds jan I. > > Regards, > Andrea. > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > >
