On 22.10.2013 23:49, Andrea Pescetti wrote:
Andre Fischer wrote:
I would now like to change the build system, especially the
solenv/bin/make_installer.pl script and its modules, so that the
installation sets it creates can be used without further changes to
create patch sets. I would also like to add the patch creation itself.

This is another feature that users have asked for several years, great to see progress here!

More details about the creation of installation sets and patches can be
found in the Wiki [2].

A question I have is what happens to the versionrc file (or equivalent on Windows). It contains hard-coded (but customizable at the system level) defaults for, e.g., the update URL. Will applying the patch overwrite it too?

Good point but no, the patch can only modify files in the 'Program Files (x86)' directory and registry entries in the registry. Well, there are the custom actions (dlls provided by us that can basically do anything) that might allow us to modify the versionrc file. But that is a second step. Alternatively we can move the URL into the registry and use the one in versionrc as a fallback on non-Windows platforms.


On one hand, leaving it as it is would create problems since OpenOffice would continue to behave as the old version when looking for updates. On the other hand, overwriting it would destroy user customizations; but this is probably what we are already doing now for full installation sets.

I would expect that overwriting is not done during the installation but when the OpenOffice is started the first time after that. That first start procedure can also be triggered after a patch is applied.

-Andre


Regards,
  Andrea.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

Reply via email to