Hi Clarence, I do not understand some part of the description. Questions inline.
Clarence GUO schrieb:
Hi~ I'm working on https://issues.apache.org/ooo/show_bug.cgi?id=122927 I delivered patch to the issue, please help to review. Root Cause: In 121126, although in description it only mentioned format code issue, actually the fix is not only for format code but also for output string for logic formula cell. The second one introduced this issue. I think the change for output string change for logic formulas is reasonable because before 12666
12666 ? , from 12666's sample file, a cell with
formula "=2>1" will return 1.0.It is very strange. It should return "TRUE" like that in MS Excel.
In all my OOo versions (from 1.1.5 over 2.4.3 to 3.41 and AOO4.0) =2>1 returns TRUE. In which version do you see result 1.0 ?
So my fix will based on 12666. The root cause is for logic formula cells, fix code of 12666 forcibly set output string to true or false. But many AOO users had manner already that set number format to logic formula cells. That's different with Excel. In Excel, no matter what number format you set to logic formula cells, the output strings are always true and false. In the sample of this issue, users set number format to currency, because of the forcibly setting, the string changed. Solution My solution is to add checking for logic formula cells, if their output number formats are certain category like number, currency, date, time, etc, we will not change the output string. but if no certain format categories were applied, for logic formula cells, will change output string to true and false.
I have applied your patch and build the source. The resulting AOO still shows the error, that FALSE and TRUE cannot be formatted to currency. The formatting to other number formats works. The error happens with IF with 1 or 2 parameters and with simple comparisons as well.
But it was not a clean build. I will try it with a clean build, but that needs half a day on my PC.
Your patch comes with DOS line ends to me. That might be a problem with my browser. But it would be nice, if you verify, that your patch has UNIX line ends.
Kind regards Regina --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
