Yes, Regina, Thank you for your suggestion. I agree with your suggestion on automatic adjust step.
Thanks & BRs, Clarence 2013/8/22 Regina Henschel <rb.hensc...@t-online.de> > Hi Clarence, > > my basis build has just finished and I need a little bit time to apply > your patch and test it. But a suggestion beforehand: You use > > sal_Int32 nStep = nEndIndex >= 20000 ? 10 : 1; > > which produces a fix percent of dropped data points, e.g. from 24000 only > 2400 would be kept. Wouldn't it be better, to make this dependent on the > amount of data points? > > Something like > > sal_Int32 nStep = nEndIndex / 20000 +1; > > ? > > Kind regards > Regina > > bugzi...@apache.org schrieb: > > Clarence GUO <clarence.guo...@gmail.com> has asked for review: >> Bug 122822: Correct viewing of XY-, Column- and Line-Charts limited to >> 10000 >> records + 1 Heading row >> https://issues.apache.org/ooo/**show_bug.cgi?id=122822<https://issues.apache.org/ooo/show_bug.cgi?id=122822> >> >> Attachment 81367: Fix patch >> https://issues.apache.org/ooo/**attachment.cgi?id=81367&**action=edit<https://issues.apache.org/ooo/attachment.cgi?id=81367&action=edit> >> >> >> ------- Additional Comments from Clarence GUO <clarence.guo...@gmail.com> >> The earlier fix patch has a problem. It cannot fix the problem of hover >> tip >> which is mentioned by Regina Henschel. >> It will always get drawing shape's name for hover tip. But drawing >> shape's name >> comes from the index when rendering these shapes. So if pick data points >> before >> rendering, the index will be always from 1 to the number it picked out. >> In order to solve this problem, picking must at view side, say rendering. >> As each chart type has it's own rendering, my fix is only in >> AreaChart.cxx. >> Area, line, XY and Radar chart share one implementation in this file. I >> tested >> sample file of 121058, it's a line chart, convert it to area, XY, radar >> charts, >> there are all performance problem. So my fix is only for these chart >> types. If >> there are performance problem for other chart types who have huge data, >> then it >> should be fixed separatedly. >> >> ------------------------------**------------------------------**--------- >> To unsubscribe, e-mail: >> dev-unsubscribe@openoffice.**apache.org<dev-unsubscr...@openoffice.apache.org> >> For additional commands, e-mail: dev-h...@openoffice.apache.org >> >> >> > > ------------------------------**------------------------------**--------- > To unsubscribe, e-mail: > dev-unsubscribe@openoffice.**apache.org<dev-unsubscr...@openoffice.apache.org> > For additional commands, e-mail: dev-h...@openoffice.apache.org > >
