On 27.05.2013 15:16, Ariel Constenla-Haile wrote:
On Mon, May 27, 2013 at 10:27:00AM +0200, Andre Fischer wrote:
Hi Ariel,
I noticed a couple of commits that you made over the weekend. Only
one of these mentioned a bug id (121542, [1]). Some of the changes
introduce incompatible API changes, some but not all of which are
mentioned in the issue comments.
that commit does not introduce an incompatible API change, on the
contrary, is the (partial) revert of one:
http://svn.apache.org/viewvc/openoffice/trunk/main/offapi/com/sun/star/awt/XPopupMenu.idl?revision=1413471&view=markup#l82
http://svn.apache.org/viewvc/openoffice/trunk/main/offapi/com/sun/star/awt/XPopupMenu.idl?revision=1425458&view=markup#l96
Can you give us a short overview of what you are doing?
As the commit message says, css::awt::XPopupMenu::execute() needs
a css::awt::Rectangle. In most cases, only X and Y are needed to
indicate the position where the PopupMenu will be executed, but in
others a rectangle is needed, for example when executing a PopupMenu in
a toolbar's drop-down click handler.
That was the only one of r1486372, r1486373, r1486374, r1486375,
r1486377, r1486379, r1486380, r1486381, and r1486438 that belonged to a
bugzilla issue. The others do not. The individual commits have
messages that describe what they are doing. What is missing is the "big
picture". Some commits seem to belong together, some seem to introduce
new functionality that other developers might be interested in. But
there is no easy and short way to know.
Take commit r1486372 as example. Its message says "Some small clean-up
to use the PopupMenu ToolbarController" but the addition of the
ExecuteHdl_Impl callback seems to imply more than just cleanup.
Or commit r1486379 "Make .uno:Open a drop-down toolbar item". What
would that drop-down menu contain? Are there code changes in other
commits that belong to this? A bugzilla issue with a little more
information would be very nice.
-Andre
[1] https://issues.apache.org/ooo/show_bug.cgi?id=121542
Regards
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org
