Thank you!
----- Messaggio originale ----- > Da: Hrishit Patel > > On Fri, Feb 1, 2013 at 3:56 PM, Pedro Giffuni wrote: > >> Thank you Hrishit! >> >> Just building it is a great step forward. That is a great advance indeed. >> >> What platform are you using? We need a diff file. >> >> On UNIX/linux you can try "man diff" and do >> something like this >> >> diff -ru original-path modified-path > diff-file.patch >> > > original-path modified-path can be files or even directories. >> You then attach the resulting diff-file.patch to the bugzilla issue. >> >> I've attached the patch file. Please someone review it. It looks good to me. > > additional issue: > It also include the fix to some other bug, the link to which i could not > find > because it has been removed from the bug-list now. > But the original repository doesnt reflect the change needed to fix it. > In the patch file lines 66-67 handles this bug. > I think you are referring to https://issues.apache.org/ooo/show_bug.cgi?id=121681 I fixed it and tested the change and I added you to the issue, even when it's closed now. Thanks! Pedro.
