On Nov 30, 2012, at 4:00 AM, Shenfeng Liu wrote: > Pavel, > Thanks for your patch! But I'd like to clarify one thing: did you take > the fix out from LO?
First I found the problem myself, fixed it only for comments without e.g. renaming variables (wrongly using "r" vars for strings etc., but it worked). And then I wanted to find another sample document which I found in LO bugzilla. And there was patch which was more extended, used proper naming of variables etc. I unified both of them, fixed other debugging code which was not properly fixed in LO patch (I have had debugging and WaE turned on in my tree because I investigated the problem before). My primary goal was not to create patch for integration but to create patch which my customer is able to use immediatelly. So yes, the patch is influenced by similar LO change and Apache OpenOffice project has to receive original author's ack. Accorging to LibreOffice' VCS, it is Cedric. I'll ask him for acknowledgement. -- Pavel Janík
