Updated the patch according to the comments...Please review https://issues.apache.org/ooo/attachment.cgi?id=79931&action=diff.Thanks.
On Tue, Oct 9, 2012 at 3:17 PM, Herbert Dürr <h...@apache.org> wrote: > I agree with Pedro that the change history belongs into the RCS, > especially in a code base as ours where some source files have had many > hundreds of changes over their history of about twenty years. > > Of course an issue reference is valuable when the comment helps to > understand what the code does and why it does it. Anything else is > distracting. > > Herbert > (sorry for top-posting) > > > On 2012/10/09 8:06 AM, chengjh wrote: > >> The comment format can provide another way to get the whole code change >> set,except svn, which is valuable for someone who has only the code >> base,is >> not familiar with the tool svn, especially,meets regression issue related >> to the code change.The comments will be quite helpful. >> >> On Tue, Oct 9, 2012 at 12:04 PM, Pedro Giffuni<p...@apache.org> wrote: >> >> Hello; >>> >>> --- Lun 8/10/12, chengjh ha scritto: >>> >>> >>> Data: Lunedě 8 ottobre 2012, 20:21 >>>> >>>> I have delivered the patch >>>> https://issues.apache.org/ooo/**attachment.cgi?id=79748&**action=diff<https://issues.apache.org/ooo/attachment.cgi?id=79748&action=diff> >>>> to >>>> improve the graphic bullet interoperability with MS Word >>>> binary document. >>>> Can any expert help the code review before I commit >>>> it?Thanks in advance. >>>> >>>> [1]Call for Test::http://s.apache.org/YYk >>>> >>>> >>> >>> Please avoid comments like >>> //begin fix for ixxxxxx >>> ... >>> //end of fix >>> >>> Such comments are useless and if someone does care that type of >>> information is registered by the version control system (SVN) anyways. >>> >>> Pedro. >>> >> -- Best Regards,Jianhong Cheng
