solomax commented on code in PR #223:
URL: https://github.com/apache/openjpa/pull/223#discussion_r4365701565
##########
openjpa-kernel/src/main/java/org/apache/openjpa/kernel/BrokerImpl.java:
##########
@@ -4318,12 +4325,50 @@ private boolean hasTransactionalObjects() {
* Return a copy of all dirty state managers.
*/
protected Collection getDirtyStates() {
+ dirtyCheckWholeConverted();
if (!hasTransactionalObjects())
return Collections.EMPTY_SET;
return _transCache.copyDirty();
}
+ /**
+ * Notify the broker that the given instance has a collection or map
+ * field that is converted as a whole, so that an element changed in
+ * place is found at flush.
+ */
+ void addWholeConverted(StateManagerImpl sm) {
+ lock();
+ try {
+ if (_wholeConverted == null)
Review Comment:
As usual I would add `{}` :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
