[ 
https://issues.apache.org/jira/browse/OPENJPA-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18131247#comment-18131247
 ] 

ASF subversion and git services commented on OPENJPA-2995:
----------------------------------------------------------

Commit 195b5a0b0a7455ea63b7a71ebf91a485055ccdd2 in openjpa's branch 
refs/heads/OPENJPA-3019 from Maxim Solodovnik
[ https://gitbox.apache.org/repos/asf?p=openjpa.git;h=195b5a0b0 ]

[OPENJPA-2995] comment was added to assertSQL method (#219)

> assertSQL now ignores identifier delimiters suite-wide
> ------------------------------------------------------
>
>                 Key: OPENJPA-2995
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2995
>             Project: OpenJPA
>          Issue Type: Sub-task
>          Components: jpa
>    Affects Versions: 4.2.0
>            Reporter: Maxim Solodovnik
>            Assignee: Maxim Solodovnik
>            Priority: Major
>             Fix For: 4.2.0
>
>
> Discussion thread: 
> https://github.com/apache/openjpa/pull/144#discussion_r3683007396
> **(medium)** assertSQL() now also matches after stripping identifier 
> delimiters (same idea as the new same() helper in 
> AbstractCriteriaTestCase.java:159). This globally relaxes every SQL assertion 
> in the suite and would mask regressions in delimited-identifier handling. 
> Could the delimiter-insensitive comparison be opt-in, or at least documented 
> why it became necessary?



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to