Thanks for the feedback: I have changed back the field types in rev 1697590 (and rev. 1697593 for 14.12); I didn't add back the localpostnew file as it didn't seem important to me (considering the limited amount of changes in that file) and also because the name could be misleading (it is not "new" but just a different field type definition).
Kind regards, Jacopo On Aug 22, 2015, at 7:43 PM, Nicolas Malin <[email protected]> wrote: > Hello, > > Jacopo you want also restore localpostnew file ? If it's the case +1 > > Nicolas > > Le 21/08/2015 12:34, Jacopo Cappellato a écrit : >> Hi all, >> >> in rev. 1530237 the sql type for Postgres for "comments" and "description" >> fields was changed from VARCHAR(255) to TEXT: >> >> https://fisheye6.atlassian.com/changelog/ofbiz/?cs=1530237 >> >> The original contribution and discussion can be found here: >> >> https://issues.apache.org/jira/browse/OFBIZ-1920 >> >> However I don't think it was a good idea and I suggest to change the types >> back to VARCHAR(255) because the new TEXT type allows strings of any length; >> all other types definitions (MySQL, Derby etc...) are using VARCHAR(255) >> thus limiting the length of "comments" and "description" fields to 255 >> characters and now Postgres is the only one that is different. >> >> In my opinion we should set postgres to VARCHAR(255) too until we will >> decide to change the size for all the dbs. >> >> Any objections? >> >> Kind regards, >> >> Jacopo >
