Re: svn commit: r1639927 [2/3] - in /ofbiz/trunk/framework/widget/src/org/ofbiz/widget: artifact/ fo/ form/ html/ text/ xml/

[Jacques Le Roux]

Hi Adrian,

I don't want to be nit picky, but I personnally prefer the 1st version (but the useless 
void after "} else if (" on 1st line)

Le 15/11/2014 22:33, adri...@apache.org a écrit :

-            } else if (
-                "value".equals(modelField.getType())
-                    || "comment".equals(modelField.getType())
-                    || "description".equals(modelField.getType())
-                    || "long-varchar".equals(modelField.getType())
-                    || "url".equals(modelField.getType())
-                    || "email".equals(modelField.getType())) {
-                ModelFormField.TextFindField textField = new 
ModelFormField.TextFindField(ModelFormField.FieldInfo.SOURCE_AUTO_ENTITY, this);
+            } else if ("value".equals(modelField.getType()) || 
"comment".equals(modelField.getType())
+                    || "description".equals(modelField.getType()) || 
"long-varchar".equals(modelField.getType())
+                    || "url".equals(modelField.getType()) || 
"email".equals(modelField.getType())) {
+                ModelFormField.TextFindField textField = new 
ModelFormField.TextFindField(FieldInfo.SOURCE_AUTO_ENTITY, this);
                  textField.setSize(60);
                  textField.setMaxlength(Integer.valueOf(250));

I find it easier to read. I saw few blocks like this.

Jacques