[
https://issues.apache.org/jira/browse/OFBIZ-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219236#comment-13219236
]
Jacopo Cappellato commented on OFBIZ-4715:
------------------------------------------
Hi Markus,
I have some suggestions to further improve your patch (and this new feature in
general):
* the two screens companyPostalAddress and postalAddress can be unified into
one generic screen with name "postalAddressPdf" or similar; the screen
definitions should be moved to the party component
* more generally, the new generic artifacts for fo-ftl that you have created
should be defined in the party component in the same locations where I have
committed the ones for fo formatting: in this way the party component will
offer a small library of templates for the formatting of html/PDF postal
addresses properly localized; then the order component (order PDF and quote
PDF) will reuse them to render the documents; could you please also move to
party component the GetPostalAddressTemplate.groovy script, the templates
PostalAddress.fo.ftl and PostalAddress_USA.fo.ftl there?
* the script that you have created with name GetPostalAddressTemplate.groovy is
very similar to the one I have committed; could you please try to merge them
into the same script? the script could accept as an additional parameter the
template suffix (.ftl or .fo.ftl) and do the lookup accordingly
* please also try to use, in the generic script/templates neutral names for
variables: please use "postalAddress" rather than "usedPostalAddress" etc...
Thanks
> Invoice PDF and Contact Information show Region Code instead of Country Code
> before the Zip Code
> ------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-4715
> URL: https://issues.apache.org/jira/browse/OFBIZ-4715
> Project: OFBiz
> Issue Type: Bug
> Components: party, specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Reporter: Markus M. May
> Assignee: Jacopo Cappellato
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments:
> OFBIZ-4715-add-locale-for-country-and-remove-countryGeo-if-not-us.patch,
> OFBIZ-4715-add-postal-address-formatting-to-fo-ftls.patch,
> OFBIZ-4715-initial-commit.patch, OFBIZ-4715-initial-commit.patch
>
>
> The Invoice PDF and the Contact Information in the Party application show the
> Region Code instead of the Country Code before the Zip Code. This will be
> fine for the US, here in Germany it is rather unusual.
> I propose to avoid this by removing the Region Code if the country is
> different then US.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
