[ 
https://issues.apache.org/jira/browse/OFBIZ-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13024774#comment-13024774
 ] 

Jacques Le Roux commented on OFBIZ-4259:
----------------------------------------

Thanks Nicolas,

Committed in trunk at r1096457.

Here is a quote of your proposition in dev ML:
{quote}
Icons is at once of the most visual but also a help user. We could 
associated directly to a themes but the reality is more complex. If I 
take the GTK project, every user can define if he wants icons, icons and 
text or only text independently of the themes.

On issue OFBIZ-4259 I do an error to use icons through img because 
although they are images, they are a more complex management.

I'm not for their exploitation only through css or style because 
although they results from it. We limit their display rendering on one 
technology et style don't allow user preference managment.

I propose to continue icons integration, add a new element in screen 
renderer that indicates what icons use on menu and form field. Thence 
following the user preference and then the themes we display icons or 
not. Whether rendering css by then or treatment with an image, it will 
be template renderer are made ​their work.

Nicolas
{quote}


> Add famfamfam icons has generic and add possibility to surchage
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-4259
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4259
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework, themes
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Assignee: Jacques Le Roux
>            Priority: Minor
>              Labels: icons, images
>             Fix For: SVN trunk
>
>         Attachments: Icons.jpg, OFBIZ-4259.patch, OFBIZ-4259.patch, 
> famfamfam.zip, remove-img-OFBIZ-4259.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> I add possibility to use famfamfam icons contains in 
> framework/images/webapp/images/icons.
> If you want use specific icon, it's possible to define a attribute 
> VT_ICONS_LOC that contains the way to themes icons directory to use
> I improve form renderer to passe a flexible string on image-location 
> attribute and screen and form renderer to display an image with a text.
> To try it, deploy famfamfam.zip on framework/images/webapp/images directory, 
> apply the patch and go to exemple component (see screenshot ;) )

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to