[ 
https://issues.apache.org/jira/browse/OFBIZ-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919626#action_12919626
 ] 

Jacques Le Roux commented on OFBIZ-3978:
----------------------------------------

Hi Sascha,

Actually I forgot (missed) to apply the OFBIZ-3978_ecommerceMigration.patch. So 
with it it works almost well. There is an issue with the popup class, see for 
instance in main feature screen (main screen). If you remove the class it works 
but then we loose the popup effect.

I have committed the slightly modified patches (see above) at r1006326  

BTW I'm not sure what you meant with 
{quote}
i deleted the not used parts, it's worth to keep them 
{quote}
I guess you spoke about the other patch. I did not remove any lines there. I 
have some questions:
# I saw that you used the new screens in CustomerScreens.xml. Then why not 
removing the old ones, are there some issues?
# Why did you comment out submitEditBillToPostalAddress snippet at bottom of 
EditBillToAddress.ftl, related to point 1?
# Same for submitEditPostalAddress_${contactMech.contactMechId} in 
EditPostalAddress.ftl
# Same for submitEditShipToPostalAddress in EditShipToAddress.ftl 
# in NewCustomer.ftl you removed the required class for some fields, should we 
not keep it for billToContactNumber and shipToContactNumber?
# in profile.js why did you remove validBillingAddress?

I did not close because we need to check more and also ans mostly because I'd 
like to commit OFBIZ-2000 (new) patch and migrate it before closing here, maybe 
it's redundant wit current code though, I did not check.

> Ecommerce Migration
> -------------------
>
>                 Key: OFBIZ-3978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3978
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: specialpurpose/ecommerce
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>         Attachments: CheckoutProcess.patch, CheckoutProcess.patch, 
> OFBIZ-3978_ecommerceMigration.patch, 
> OFBIZ-3978_onePageCheckOutMigration.patch, 
> OFBIZ-3978_onePageCheckOutMigration.patch, 
> OFBIZ-3978_onePageCheckOutMigration.patch, smoothness.zip
>
>
> All ecommerce js migration.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to