From: "Ean Schuessler" <[email protected]>
To: <[email protected]>
Sent: Friday, December 18, 2009 10:44 PM
Subject: Re: svn commit: r890175 [1/2] - in /ofbiz/trunk: ./ applications/content/ applications/content/data/ framework/
framework/base/config/ framework/birt/ framework/birt/config/ framework/birt/data/ framework/birt/data/helpdata/ framework/birt/lib/
framework/b...
Scott Gray wrote:
Selective quoting FTW?
"For small amounts of source that is directly consumed by the ASF
product at runtime in source form, and for which that source is
unlikely to be changed anyway (say, by virtue of being specified by a
standard), this action is sufficient. An example of this is the
web-facesconfig_1_0.dtd, whose inclusion is mandated by the JSR 127:
JavaServer Facesspecification.
Code that is more substantial, more volatile, or not directly consumed
at runtime in source form may only be distributed in binary form."
Small amount of source? I don't consider an entire 45 file javascript
library and 37 jsp files to be a small amount of source.
Unlikely to be changed? The javascript perhaps but I think there is a
decent chance of a downstream user changing the jsp files
I suppose it depends on what you decide is a "more substantial" amount
of code. Is the limit 34K? (the size of the example DTD) That seems
arbitrary to me. The .js, .jsp and .css files, taken together constitute
1.7% of the BIRT runtime, and they are uncompressed. That seems fairly
insubstantial to me but I suppose we must at this point defer to higher
authorities.
Yes, it's all about that. As IIRW it has been already said, I don't think it's
a problem for the code already commited.
The intention is more important, anybody can make an error, intentionally not repairing this error is where the real problems
begin...
At least it's how I see justice. And anyway as long as nobody as modified and
distributed this code it's not a problem, is it?
It does seem crystal clear that including the BIRT runtime as a WAR is
in compliance because it "reduces the exposed surface area" of the code.
If they want to split that hair I suppose we can go that way or write a
ROT13 decoder to strap onto the JSP resource loader.
Maybe the solution
Jacques
--
Ean Schuessler, CTO
[email protected]
214-720-0700 x 315
Brainfood, Inc.
http://www.brainfood.com
