[
https://issues.apache.org/jira/browse/OFBIZ-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788776#action_12788776
]
Adrian Crum commented on OFBIZ-3274:
------------------------------------
Bruno,
This looks better. A few minor changes are needed:
1. Give the MultiColumnApplicationDecorator a more specific name - like
TwoColumnDecorator - so developers will know what it does.
2. Multi-column decorators should be kept in framework/common so the framework
applications can have access to them.
3. We need to accommodate the sight impaired - see the note in
CommonScreens.xml:
{code}
<!-- Please don't change the column-container id : it's referenced to allow
skipping navigation-->
{code}
Maybe have something like:
{code}
<container id="content-main-section">
<decorator-section-include name="body"/>
</container>
{code}
in the GlobalDecorator, then update the theme templates to skip to
content-main-section instead of column-container. That change might affect
layout though. Feel free to come up with a better solution. The bottom line is,
the body section needs to be wrapped with a container that can be skipped to.
Again, some of this is outside the scope of the original issue. There are
actually two tasks that need to be accomplished: fix the bad GlobalDecorator
design and then implement the decorators you proposed.
> Using decorator sections to control the left-bar
> ------------------------------------------------
>
> Key: OFBIZ-3274
> URL: https://issues.apache.org/jira/browse/OFBIZ-3274
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Assignee: Bruno Busco
> Attachments: OFBIZ-3274 DecoratorSectionLayout.patch, OFBIZ-3274
> DecoratorSectionLayout.patch, OFBIZ-3274 DecoratorSectionLayout.patch
>
>
> Hi,
> at the moment, in order to have a screen rendered with or without a left bar,
> the variables "leftbarScreenName", "leftbarScreenLocation" and
> "MainColumnStyle" need to be set to select a screen for the left bar and a
> main column style.
> This must be done in the screen itself or an application decorator.
> With the attached patch, submitted for your review, a new GlobalDecorator
> section named "left-bar" has been added. If a screen must be displayed with a
> left bar this new decorator section needs to be filled with the selected
> content.
> The main column style is defined in the Global decorator. In order to do this
> a new screen condition has been added: "if-empty-decorator-section". This
> condition allows to check if a decorator section has been added content or
> not. (actually it only checks if the decorator section has been defined).
> In the patch I updated all catalog application screens to use this new method.
> If there are no problems with you with this, I will commit in the next days.
> Thank you for sharing your thoughts about.
> -Bruno
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
