Hi Andy, thanks for reporting this. I should have found this, sorry about that.
I have now updated the e-commerce component in rev 781649 and add the messages to the top menu to make this more visible. One thing i did update and could not test very well is communicationEventServices.java, there is service which is called by an external request and is called: markCommunicationAsRead i tried to do the request: http://localhost:8080/partymgr/control/ceimages but get a null pointer exception at line 1223 perhaps you can explain how this service should work and perhaps can help here? Regards, Hans On Wed, 2009-06-03 at 13:39 -0400, Andrew Zeneski wrote: > Hans, > > This change has broken the functionality which marks outgoing (email) > communication events as read when the user opens the message. The > functionality uses the markCommEventRead which still references the > COM_READ status. Before removing something from a data file, please > make sure you have searched and updated all the code which references > that data. > > Doing a quick search for COM_ROLE_READ I am not finding any logic > which ties this in yet. So, either this service needs to be updated, > or we need to add back in the COM_READ status and the > StatusValidChange records. > > Please let me know your plans for this. > > Andrew > > On May 27, 2009, at 12:20 AM, [email protected] wrote: > > > Author: hansbak > > Date: Wed May 27 04:20:31 2009 > > New Revision: 778988 > > > > URL: http://svn.apache.org/viewvc?rev=778988&view=rev > > Log: > > added comments to commevent status, removed the COM_READ status as > > COM_ROLE_READ status is now used > > > > Modified: > > ofbiz/trunk/applications/party/data/PartyTypeData.xml > > ofbiz/trunk/applications/party/webapp/partymgr/communication/ > > CommForms.xml > > > > Modified: ofbiz/trunk/applications/party/data/PartyTypeData.xml > > URL: > > http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/data/PartyTypeData.xml?rev=778988&r1=778987&r2=778988&view=diff > > = > > = > > = > > = > > = > > = > > = > > = > > ====================================================================== > > --- ofbiz/trunk/applications/party/data/PartyTypeData.xml (original) > > +++ ofbiz/trunk/applications/party/data/PartyTypeData.xml Wed May 27 > > 04:20:31 2009 > > @@ -300,27 +300,22 @@ > > <StatusType description="Case" hasTable="N" parentTypeId="" > > statusTypeId="CASE_STATUS"/> > > > > <StatusType description="Communication Event" hasTable="N" > > parentTypeId="" statusTypeId="COM_EVENT_STATUS"/> > > - <StatusItem description="Entered" sequenceId="01" > > statusCode="ENTERED" statusId="COM_ENTERED" > > statusTypeId="COM_EVENT_STATUS"/> > > - <StatusItem description="Pending" sequenceId="02" > > statusCode="PENDING" statusId="COM_PENDING" > > statusTypeId="COM_EVENT_STATUS"/> > > - <StatusItem description="Read" sequenceId="03" > > statusCode="READ" statusId="COM_READ" > > statusTypeId="COM_EVENT_STATUS"/> > > - <StatusItem description="In-Progress" sequenceId="05" > > statusCode="IN_PROGRESS" statusId="COM_IN_PROGRESS" > > statusTypeId="COM_EVENT_STATUS"/> > > - <StatusItem description="Unknown Party" sequenceId="07" > > statusCode="UNKNOWN_PARTY" statusId="COM_UNKNOWN_PARTY" > > statusTypeId="COM_EVENT_STATUS"/> > > + <StatusItem description="Pending" sequenceId="01" > > statusCode="PENDING" statusId="COM_PENDING" > > statusTypeId="COM_EVENT_STATUS"/><!-- draft version, only visible by > > originator --> > > + <StatusItem description="Entered" sequenceId="02" > > statusCode="ENTERED" statusId="COM_ENTERED" > > statusTypeId="COM_EVENT_STATUS"/> > > + <!--StatusItem description="Read" sequenceId="03" > > statusCode="READ" statusId="COM_READ" > > statusTypeId="COM_EVENT_STATUS"/--><!-- the read status is > > maintained at the comm-role level; can be diffrent for all > > participants--> > > + <StatusItem description="In-Progress" sequenceId="05" > > statusCode="IN_PROGRESS" statusId="COM_IN_PROGRESS" > > statusTypeId="COM_EVENT_STATUS"/><!-- waiting to be sent --> > > + <StatusItem description="Unknown Party" sequenceId="07" > > statusCode="UNKNOWN_PARTY" statusId="COM_UNKNOWN_PARTY" > > statusTypeId="COM_EVENT_STATUS"/><!-- unknown incoming email address > > --> > > <StatusItem description="Closed" sequenceId="20" > > statusCode="COMPLETE" statusId="COM_COMPLETE" > > statusTypeId="COM_EVENT_STATUS"/> > > <StatusItem description="Resolved" sequenceId="21" > > statusCode="RESOLVED" statusId="COM_RESOLVED" > > statusTypeId="COM_EVENT_STATUS"/> > > <StatusItem description="Referred" sequenceId="22" > > statusCode="REFERRED" statusId="COM_REFERRED" > > statusTypeId="COM_EVENT_STATUS"/> > > <StatusItem description="Bounced" sequenceId="50" > > statusCode="BOUNCED" statusId="COM_BOUNCED" > > statusTypeId="COM_EVENT_STATUS"/> > > <StatusItem description="Cancelled" sequenceId="99" > > statusCode="CANCELLED" statusId="COM_CANCELLED" > > statusTypeId="COM_EVENT_STATUS"/> > > - <StatusValidChange condition="" statusId="COM_ENTERED" > > statusIdTo="COM_PENDING" transitionName="Set Pending"/> > > - <StatusValidChange condition="" statusId="COM_ENTERED" > > statusIdTo="COM_READ" transitionName="Read"/> > > + <StatusValidChange condition="" statusId="COM_ENTERED" > > statusIdTo="COM_PENDING" transitionName="Set Pending, only visible > > to originator"/> > > <StatusValidChange condition="" statusId="COM_ENTERED" > > statusIdTo="COM_COMPLETE" transitionName="Complete"/> > > - <StatusValidChange condition="" statusId="COM_PENDING" > > statusIdTo="COM_READ" transitionName="Read"/> > > - <StatusValidChange condition="" statusId="COM_PENDING" > > statusIdTo="COM_IN_PROGRESS" transitionName="Set In Progress"/> > > - <StatusValidChange condition="" statusId="COM_READ" > > statusIdTo="COM_IN_PROGRESS" transitionName="Set In Progress"/> > > - <StatusValidChange condition="" statusId="COM_READ" > > statusIdTo="COM_COMPLETE" transitionName="Complete"/> > > - <StatusValidChange condition="" statusId="COM_IN_PROGRESS" > > statusIdTo="COM_READ" transitionName="Read"/> > > + <StatusValidChange condition="" statusId="COM_PENDING" > > statusIdTo="COM_ENTERED" transitionName="Entered,visible to all > > participants"/> > > + <StatusValidChange condition="" statusId="COM_PENDING" > > statusIdTo="COM_IN_PROGRESS" transitionName="Set In Progress, > > waiting to be send"/> > > <StatusValidChange condition="" statusId="COM_IN_PROGRESS" > > statusIdTo="COM_COMPLETE" transitionName="Complete"/> > > <StatusValidChange condition="" statusId="COM_IN_PROGRESS" > > statusIdTo="COM_BOUNCED" transitionName="Bounced"/> > > - <StatusValidChange condition="" statusId="COM_COMPLETE" > > statusIdTo="COM_READ" transitionName="Read"/> > > <StatusValidChange condition="" statusId="COM_COMPLETE" > > statusIdTo="COM_RESOLVED" transitionName="Resolve"/> > > <StatusValidChange condition="" statusId="COM_COMPLETE" > > statusIdTo="COM_REFERRED" transitionName="Refer"/> > > <StatusValidChange condition="" statusId="COM_COMPLETE" > > statusIdTo="COM_BOUNCED" transitionName="Bounced"/> > > @@ -330,7 +325,6 @@ > > > > <StatusValidChange condition="" statusId="COM_ENTERED" > > statusIdTo="COM_CANCELLED" transitionName="Cancel"/> > > <StatusValidChange condition="" statusId="COM_PENDING" > > statusIdTo="COM_CANCELLED" transitionName="Cancel"/> > > - <StatusValidChange condition="" statusId="COM_READ" > > statusIdTo="COM_CANCELLED" transitionName="Cancel"/> > > <StatusValidChange condition="" statusId="COM_IN_PROGRESS" > > statusIdTo="COM_CANCELLED" transitionName="Cancel"/> > > <StatusValidChange condition="" statusId="COM_COMPLETE" > > statusIdTo="COM_CANCELLED" transitionName="Cancel"/> > > <StatusValidChange condition="" statusId="COM_RESOLVED" > > statusIdTo="COM_CANCELLED" transitionName="Cancel"/> > > > > Modified: ofbiz/trunk/applications/party/webapp/partymgr/ > > communication/CommForms.xml > > URL: > > http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/webapp/partymgr/communication/CommForms.xml?rev=778988&r1=778987&r2=778988&view=diff > > = > > = > > = > > = > > = > > = > > = > > = > > ====================================================================== > > --- ofbiz/trunk/applications/party/webapp/partymgr/communication/ > > CommForms.xml (original) > > +++ ofbiz/trunk/applications/party/webapp/partymgr/communication/ > > CommForms.xml Wed May 27 04:20:31 2009 > > @@ -193,7 +193,7 @@ > > <field name="send" title=" " position="1" use- > > when="communicationEvent!=null"> > > <hyperlink also-hidden="true" > > target-type="plain" description="$ > > {uiLabelMap.CommonSend}" > > - target="javascript: > > (document.EditInternalNote.statusId.value='COM_COMPLETE'), > > (document.EditInternalNote.datetimeStarted.value='${nowDate}'), > > (document.EditInternalNote.submit())"/> > > + target="javascript: > > (document.EditInternalNote.statusId.value='COM_ENTERED'), > > (document.EditInternalNote.datetimeStarted.value='${nowDate}'), > > (document.EditInternalNote.submit())"/> > > </field> > > <field name="save" title=" " position="2" use- > > when="communicationEvent!=null"> > > <hyperlink also-hidden="true" target-type="plain" > > description="${uiLabelMap.CommonSave}" target="javascript: > > (document.EditInternalNote.submit())"/> > > > > > -- Antwebsystems.com: Quality OFBiz services for competitive rates
