Hello Jacopo, Thank you. I am looking into the failed test.
-- Thanks, Ashish Vijaywargiya On Thu, 28 May 2026 at 12:44, Jacopo Cappellato <[email protected]> wrote: > Hi Ashish, > > After you have fixed the typo, one test is failing. I didn't investigate > it, but I suspect that the "testBigDecimal" property is used elsewhere and > unsetting it makes the test fail. It was working before because, thanks to > the typo, the property was not unset. The two errors were cancelling out > each other :-( > > Jacopo > > On Thu, May 28, 2026 at 7:04 AM <[email protected]> wrote: > > > This is an automated email from the ASF dual-hosted git repository. > > > > ashishvijaywargiya pushed a commit to branch trunk > > in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git > > > > > > The following commit(s) were added to refs/heads/trunk by this push: > > new 5b32998eb3 Fixed a typo from the following commit: > > 5b32998eb3 is described below > > > > commit 5b32998eb38f0ea77e306384038273b6a9161fda > > Author: Ashish Vijaywargiya <[email protected]> > > AuthorDate: Thu May 28 10:30:23 2026 +0530 > > > > Fixed a typo from the following commit: > > > > > > > https://github.com/apache/ofbiz-framework/commit/d6993ecabb311b2cf59f343072d78b5db666e815 > > --- > > .../base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java > | > > 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git > > > a/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java > > > b/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java > > index c5cacbfd8d..bc7c41703d 100644 > > --- > > > a/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java > > +++ > > > b/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java > > @@ -496,7 +496,7 @@ public class ObjectTypeTests { > > System.setProperty("testBigDecimal", "bypassLocaleChange"); > > simpleTypeOrObjectConvertTestSingleMulti("BigDecimal->String", > > new BigDecimal("12345.67"), > > new String[] {"String", "java.lang.String"}, null, > > LOCALE_DATA, "12,345.67"); > > - System.clearProperty("testBigDecima"); > > + System.clearProperty("testBigDecimal"); > > > > simpleTypeOrObjectConvertTestSingleMulti("BigDecimal->BigDecimal", dcml, > > new String[] {"BigDecimal", "java.math.BigDecimal"}, new > > BigDecimal("781.25")); > > simpleTypeOrObjectConvertTestSingleMulti("BigDecimal->Double", > > dcml, > > > > >
