Thanks Jacques! It works I tried creating a PR by comparing trunk to my fork branches and content from template show up.
>> I don't think it's a problem, since it's only related to GH, but I don't see .github in Windows. I think this might not be a problem until you got to change it ;) Thanks and Regards, Aditya Sharma On Wed, May 27, 2020 at 7:57 PM Jacques Le Roux < [email protected]> wrote: > Note (also added as a comment in OFBIZ-11722): > > As the Github PR template is not related to OFBiz I followed this GH > advice: > > To store your file in a hidden directory, name the pull request > template .github/pull_request_template.md. > > I don't think it's a problem, since it's only related to GH, but I don't > see .github in Windows. Using Git Bash: > > Jacques@LDLC MINGW64 /c/projectsASF/Git/ofbiz-framework (trunk) > $ git pull > Current branch trunk is up to date. > > Jacques@LDLC MINGW64 /c/projectsASF/Git/ofbiz-framework (trunk) > $ cd .github > bash: cd: .github: No such file or directory > > Jacques > > Le 27/05/2020 à 11:04, Jacques Le Roux a écrit : > > Done, please review and amend if necessary > > > > Le 22/05/2020 à 12:45, Jacques Le Roux a écrit : > >> I created https://issues.apache.org/jira/browse/OFBIZ-11722 for that > >> > >> Jacques > >> > >> Le 13/05/2020 à 12:13, Jacques Le Roux a écrit : > >>> Hi Deepak, > >>> > >>> Agreed, we had this discussion earlier: > https://markmail.org/message/3l6dwx4vkknmovew > >>> > >>> We just miss a sub-task under > https://issues.apache.org/jira/browse/OFBIZ-11268 > >>> > >>> HTH > >>> > >>> Jacques > >>> > >>> Le 13/05/2020 à 12:06, Pierre Smits a écrit : > >>>> +1. And our current contributor pages in the wiki should be updated > >>>> accordingly. > >>>> > >>>> Met vriendelijke groet, > >>>> > >>>> Pierre Smits > >>>> *Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> > since > >>>> 2008 (without privileges) > >>>> > >>>> *Apache Trafodion <https://trafodion.apache.org>, Vice President* > >>>> *Apache Directory <https://directory.apache.org>, PMC Member* > >>>> Apache Incubator <https://incubator.apache.org>, committer > >>>> Apache Steve <https://steve.apache.org>, committer > >>>> > >>>> > >>>> On Wed, May 13, 2020 at 12:02 PM Deepak Dixit <[email protected]> > wrote: > >>>> > >>>>> Hi Dev, > >>>>> > >>>>> I think we should add the github PR request [1] template for ofbiz > >>>>> repositories. > >>>>> It will help to guide new contributors to follow our practices and > we will > >>>>> have a generic template for PR. > >>>>> > >>>>> [1] > >>>>> > >>>>> > https://help.github.com/en/github/building-a-strong-community/creating-a-pull-request-template-for-your-repository > >>>>> > >>>>> Thanks & Regards > >>>>> -- > >>>>> Deepak Dixit > >>>>> ofbiz.apache.org > >>>>> >
