Hi Jacques, All looks good to me, thanks.
The branch used for PR37 was taken from PR31's branch, which means there was some shared commits. >From the git log it looks like you merged PR37, which would explain why all the commits from PR31 were merged as well. Thanks, Dan. On Mon, 9 Mar 2020 at 13:32, Jacques Le Roux <[email protected]> wrote: > Hi Daniel, > > Done, please check I did not miss anything. I was a bit confused because > when I merged PR31 it seem PR37 was automatically merged too. > > If all is OK I'll continue on OFBIZ-4035 > > Thanks > > Jacques > > Le 06/03/2020 à 18:03, Jacques Le Roux a écrit : > > Hi Daniel, All, > > > > At https://markmail.org/message/ahu6kz7dihcyp45z you asked > > > > "How do committers decide which features to backport to 18.12?" > > > > I (roughly) answered > > > > "The rule is normally we only backport bug fixes, obviously to avoid > regression. But if nobody disagree for simple new features or improvements > > sometimes we backport" > > > > I have decided I'll backport after the weekend OFBIZ-11415 & OFBIZ-11418 > in at least R18 if nobody is against > > > > As I said already, I'm also considering the related OFBIZ-4035 and will > work on it next week, if nobody beats me on it... > > > > Jacques > > > > Le 25/02/2020 à 15:04, Daniel Watford a écrit : > >> Hello, > >> > >> I've created https://issues.apache.org/jira/browse/OFBIZ-11415 as a > >> request to backport functionality introduced to trunk by > >> https://issues.apache.org/jira/browse/OFBIZ-11330. > >> > >> PR created: https://github.com/apache/ofbiz-framework/pull/31 > >> > >> Thanks, > >> > >> Dan. > >> > -- Daniel Watford
