Daniel Watford <[email protected]> writes: > We already have a +1 from James. Can I count on your vote, Mathieu? :)
You have a +0 on my side. As I already said I support the testing effort because OFBiz need people caring about writing maintainable tests and I found legitimate to introduce an extra mocking library dependency to mitigate the poor testability of current implementation even if it is not ideal. > Regarding the example argument “JMockit is redundant with Mockito purpose > which is already used”: > I hope I've demonstrated in this thread that Mockito is not fit for purpose > in this particular case due to the architecture of the MacroFormRenderer > class; and that refactoring MacroFormRenderer without the support of tests > is risky and therefore a worse proposition that introducing JMockit. > Therefore a veto with that particular argument shouldn't be considered > valid. I don't think this demonstration can effectively prove that this hypothetical technical argument is invalid because “worse” depends on the perspective and software is always about trade-offs meaning that something that is “worse” in some facet is “better” in another. Imagine a potential PMC member who cares more about the size of the artifact footprint than about the actual test coverage. With a bit of insistance combined with a dose of FUD [1] (...customers will drop OFBiz, ...this will introduce dependency incompatibilities) she can easily make it appear as a valid “technical” argument to some doubtful people. So the best you can do is to demonstrate that something is more desirable than some alternative trade-offs with the limit that you have a finite time to spend on that thing and that people can have infinitely many alternatives in mind. Which mean concretely in the presence of stubborn or dishonest people no way to demonstrate anything. ;-) This is going off-topic and since nobody is currently making such kind of arguments so let's drop this discussion. :-) Thanks. [1] https://en.wikipedia.org/wiki/Fear%2C_uncertainty%2C_and_doubt -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
