Please review below the new section that I have added to the README documents that will be part of the release, to document how to get the Gradle wrapper; in my opinion we should remove the wrapper from the trunk and from all the release branches and include these notes in all the README files, but this is a discussion for another day, for now I will be focusing on this release only.
Thanks Jacopo ======================================================= diff --git a/README.adoc b/README.adoc index e606462428..18b8d0420f 100644 --- a/README.adoc +++ b/README.adoc @@ -69,6 +69,13 @@ https://medium.com/@javachampions/java-is-still-free-2-0-0-6b9aa8d6d244[To know To quickly install and fire-up OFBiz, please follow the below instructions from the command line at the OFBiz top level directory (folder). +[[download-the-gradle-wrapper]] +=== Download the Gradle wrapper: + +MS Windows: `init-gradle-wrapper` + +Unix-like OS: `./gradle/init-gradle-wrapper` + [[prepare-ofbiz]] === Prepare OFBiz: diff --git a/README.md b/README.md index 33c394ff67..4dabb2f5c7 100644 --- a/README.md +++ b/README.md @@ -59,6 +59,14 @@ from the command line at the OFBiz top level directory (folder) In case of problems visit our [Further reading section](#further-reading) +### Download the Gradle wrapper: + +MS Windows: +`init-gradle-wrapper.bat` + +Unix-like OS: +`./gradle/init-gradle-wrapper` + ### Prepare OFBiz: >_Note_: Depending on your Internet connection speed it might take a long ======================================================= On Thu, Feb 20, 2020 at 4:57 PM Jacopo Cappellato < [email protected]> wrote: > On Thu, Feb 20, 2020 at 4:26 PM Nicolas Malin <[email protected]> > wrote: > >> Jacopo, >> >> During my check I saw that this archive contains the gradle wrapper. >> It's a forget or just me that not understand the finality of >> https://issues.apache.org/jira/browse/OFBIZ-10145 >> >> Nicolas > > > This is a good catch Nicolas! > With all the back and forth and several comments in that ticket I don't > recall what was the final decision: should I simply remove the > gradle-wrapper.jar file from the release archive? I guess we should also > update our README file with the step to run the init-gradle-wrapper.sh > script: any committer/volunteer to perform this task in the trunk and in > our two release branches? > Once this is done I will prepare new files and start a new vote. > > Thanks, > > Jacopo > > >
