I think the change is fine as raiden mentioned since I do remember seeing this discussion. However the PR does need testing.
Xiang, if you're reading this, please let us know if there's any way we can help you test this change (as people did for me with the change to the init logic). Best, Matteo On Sun, May 3, 2026, 8:17 AM raiden00pl <[email protected]> wrote: > 32 bit time is not compatible with the latest POSIX and it was already > agreed that this change would be included in release 13 in one of > the previous discussions on this topic. We were just waiting for release > 13. > > niedz., 3 maj 2026 o 13:52 Alan C. Assis <[email protected]> napisał(a): > > > Hi Everyone, > > I want to bring this PR to your attention: > > https://github.com/apache/nuttx/pull/18840 > > > > I have some concerns like those added to my Change Request there. > > > > I think broad modifications like this need to be discussed with our > > community. > > > > I'm not against this PR, it will avoid the 2038 Unix Epoch BUG, but it is > > important to know first the impact of this commit to small > > microcontrollers. > > > > Unfortunately we don't have how many bytes this PR will add/remove > to/from > > Flash and RAM. > > > > Also we discussed many times that all PRs need to include valid testing, > > just "checkpatch.sh -f" is not a real test, it doesn't guarantee that the > > PR will pass in the CI. > > > > In cases like this where a PR modifies many boards and MCUs, a good idea > it > > to test it on your own github account first, before submitting the PR, as > > explained here: https://github.com/apache/nuttx/issues/18568 > > > > This is not a criticism of the author, that is my friend, but it is > > important that we improve our process. Seems like we are still messing > with > > basic things. > > > > BR, > > > > Alan > > >
