Hi KR, Actually you shouldn't edit the Kconfig manually. Please see inside these files, there is this disclaimer:
# # This file is autogenerated: PLEASE DO NOT EDIT IT. # # You can use "make menuconfig" to make any modifications to the installed .config file. # You can then do "make savedefconfig" to generate a new defconfig file that includes your # modifications. You should modify options inside menuconfig, save it and create a new defconfig, basically these are the steps you should follow: $ ./tools/configure.sh boardname:profilename $ make menuconfig $ make savedefconfig $ mv defconfig to boards/arch/chip/boardname/configs/profilename/ BR, Alan On Wed, May 14, 2025 at 6:20 AM <kr....@kerogit.eu> wrote: > Hello, > > thanks for letting me know and thanks to the people reviewing the PR. > Based on their feedback, I prepared version 2 of the patches: > > The elimination of unused sections patch (0004) was reworked. I have to > admit that I only have user experience with Kconfig (Linux kernel build) > and no developer experience. I did not know that the comment "# > CONFIG_SOMETHING is not set" will actually affect something, nor that > you are not supposed to set something to "no". The defconfig files are > now altered based on xiaoxiang781216's advice. I tested it again by > building mega1284p-xplained:nsh and it worked correctly. The option was > unselected after running tools/configure.sh and the interrupts vectors > were present in the built binary. > > I also removed the comments from the defconfig files. Instead, the > notices are added into Documentation for every board that has a > directory there. > > The patch that fixes missing dependency in Kconfig (0003) now also > removes brackets in the "depends on" clause based on xiaoxiang781216's > feedback. (There was no comment other than copy of the line in the patch > without the brackets so I hope I correctly understood what was suggested > there.) Tested in menuconfig, it seems the dependency works correctly > this way. > > There is an additional patch (0006) now too. I noticed that two files > added into Documentation by my previous patch series leaked into table > of contents, one to the list of supported platforms, one to the list of > supported AVR families. I created a subdirectory for both of those files > and added link to them in respective index.rst files. Tested by building > the documentation into HTML using make html and it seems to be correct > now. > > Patches are available in avrdx_fixes_v2 and also attached. > > Thanks again to everyone for the help. > > On 2025-05-13 09:55, Alin Jerpelea wrote: > > The patches are submitted > > https://github.com/apache/nuttx/pull/16365 > > > > Thanks for enhancing the AVR platform > > > > Best regards > > Alin > > >
