Hello Tim,

On Friday 28 of March 2025 11:22:06 Tim Hardisty wrote:
> Pavel - I have been thinking about your point regarding copying the
> (simple) nxboot_main and using it as a starting point for a more
> sophisticated application. What *I* want is probably not want *others*
> want and it could grow out of hand.
>
> Let's leave it as is...so it covers the stdout/stderr/syslog/printf
> output choices to me along with error recovery.

I think that allow to make that configurable is OK or even
welcomed for Elektroline team. The disable systlog for really
small code size makes sense.

I would suggest to replace syslog(LOG_ERR,...) and
syslog(LOG_INFO, ...) in nxboot_main.c, loader/boot.c
and loader/flash.c by nxboot_report_error and
nxboot_report_info or something similar and implement
them as functions which are implemented under some
ifdef for syslog (probably default), standard and
error output. The nxboot_report_error and nxboot_report_info
has to switch to vsyslog, vprintf, vfprintf....
Or the macro can be used directly to route to the correct
function. There would worth input form Michal Lenc
what their team prefers. But in general, make this
configurable when it does not add too  much complexity
and code is OK.

On the other hand option for splash screen and boot reporter
to listen on syslog could be good option for larger systems
where more possible failures could be reported to user this
way and it is standard that drivers and kernel internal
subsystems reports failures this way. 

> This discussion now only hinges on splashscreen which, from another
> branch of this discussion, I think is looking more likely a better fit
> in the kernel as part of the framebuffer registration, but will wait and
> see how that bottoms out.

Agree, general spash screen is independent but generally
usesfull option.

Best wishes,

                Pavel

                Pavel Pisa

    phone:      +420 603531357
    e-mail:     p...@cmp.felk.cvut.cz
    Department of Control Engineering FEE CVUT
    Karlovo namesti 13, 121 35, Prague 2
    university: http://control.fel.cvut.cz/
    personal:   http://cmp.felk.cvut.cz/~pisa
    company:    https://pikron.com/ PiKRON s.r.o.
    Kankovskeho 1235, 182 00 Praha 8, Czech Republic
    projects:   https://www.openhub.net/accounts/ppisa
    social:     https://social.kernel.org/ppisa
    CAN related:http://canbus.pages.fel.cvut.cz/
    RISC-V education: https://comparch.edu.cvut.cz/
    Open Technologies Research Education and Exchange Services
    https://gitlab.fel.cvut.cz/otrees/org/-/wikis/home

Reply via email to