I will just tell one generic thing:
Please just dont push commits just to change the code style globally.
What is written is written.
Messing *all* developer working copies with huge diffs just for code
formatting is a no-go. This will prevent bissections and backports.
Define some relevant rules for new code if you want, but please dont
rewrite the full nuttx codebase just for the pleasure of the eyes (or
the pleasure to use a new toy^H^H^Htool).
Sebastien
On 19/03/2025 08:43, raiden00pl wrote:
K&R is ugly and unreadable. It will also mess up git history a lot, so I'll
definitely vote against it.
Allman is much more acceptable, but style change is a significant change
for the project,
and there's been a lot of complaining here lately about "big changes".
śr., 19 mar 2025 o 02:03 Michał Łyszczek <michal.lyszc...@bofc.pl>
napisał(a):
Nathan Hartman:
But, if there's going to be a discussion about brace styles, I would vote
for K&R's One True Brace Style. :-)
I agree that K&R is the way to go. But. Switching to Allman is just
removing
2 spaces on lines where bracket is. Change is trivial and will not mess
with
the history.
In theory going to K&R is simple too. Basically same check as with Allman,
but instead of removing 2 spaces you remove all spaces + previous new line
character. But this will impact history, as all if/for/while will have an
altered line where check is happening.
tl;dr: K&R is more compact, but will mess with history. Allman will be just
as vertically wide as GNU, but will leave history intact where it matters.
I am down to any change that removes that awful GNU indent :)
