I am redirecting questions from Takashi to this thread :-) On Wed, Feb 12, 2025 at 6:45 AM Takashi Yamamoto <yamam...@midokura.com.invalid> wrote: > On Tue, Feb 11, 2025 at 8:37 AM Tomek CEDRO <to...@cedro.info> wrote: > > 7. Each git commit message must consist of topic, description, and > > signature, which are mandatory, or change is auto-rejected until fixed > > / updated. Topic consists of functional prefix, ":" mark, and short > > self-explanatory context. Description is separated from topic with a > > single blank line. Example already presented in Contributing > > Guidelines. > > what's "signature" in this context?
This is simple "sign-off" perfomed by `git commit -s` so we can see the git commit author name and email address, those information should be valid, we should add that info right? I don't think we require some sort of agreeements from committers, nor signing with cryptography like gpg/pgp right? > > 16. Single company commit, review, merge is not allowed. > > how do you attribute people to companies/organizations? Good question. At the moment one person from organization X can send commits / pr, two people from organization X can approve, and the code is merged. This was the concern raised in recent discussions. The idea is that single organization / company / university does not push their changes without cross-check, especially when code is untested, breaking, or pr / commits are not well described / discussed. Thus my idea for 4 independent reviews not 2. But there may be other ways to solve this? Our committers should have company / affiliation assigned so things are crystal clear. https://nuttx.apache.org/community-members/ There is only affiliation filled in :-P Thank you! :-) Tomek -- CeDeROM, SQ7MHZ, http://www.tomek.cedro.info
