> This is not an Apache Project communication channel, so it does not > exist as far as we are all concerned.
actually we've had extensive discussions on the community PR, but no one has ever cared about this issue. I would feel highly honored if I could get some tips from you. https://github.com/apache/nuttx/pull/15705 > As a general rule, please stop testing your changes in prod, I know you > refuse to reply to me but you read anyway. I just haven't figured out how to reply to you. I agree with your opinion, However, could you please refrain from criticizing others with prejudice? I could have chosen not to send this email. But I hope that we can have further discussions to make the revisions even more perfect. > If I understand correctly spinlocks are basically a no-op when no SMP is involved, which is the majority of CPUs supported by NuttX. You shall not break all platforms. > I urge you all to revert any commit that might have broken something in this domain, redesign it carefully on your own code fork, and then push a final working version to nuttx. I'm also really grateful for your advice. I believe everything is getting better. BRs, Sebastien Lorquet <sebast...@lorquet.fr> 于2025年2月5日周三 22:01写道： > Hi, > > On 05/02/2025 13:03, chao an wrote: > > I talked with > > Xiaoxiang in WeChat before. > > This is not an Apache Project communication channel, so it does not > exist as far as we are all concerned. > > > These changes MUST be tested in a separate code branch so all platforms > can be tested and validated for several weeks. > > We need an explicit GO on every supported arch (SMP and not SMP) before > this goes into main/master. > > These are critical core changes that have potential to introduce very > nasty bugs that will be very hard to track. > > It may take time to validate all of this, and this delay is fine. > > > As a general rule, please stop testing your changes in prod, I know you > refuse to reply to me but you read anyway. > > > Sebastien > >
