> > Nxstyle is not a problem unless we have compilation issues. > We had various nxstyle errors before and we fixed them as we touched the > files.
I agree that this should not stop a release. *Changing my vote to +1 (binding)*. Thanks, Alin! Best regards Em sex., 3 de jan. de 2025 às 14:32, Alin Jerpelea <jerpe...@gmail.com> escreveu: > Thanks Filipe, > > I appreciate the effort to test all those boards and validate the release > > Best regards > Alin > > On Fri, 3 Jan 2025, 18:25 Filipe Cavalcanti, > <filipe.cavalca...@espressif.com.invalid> wrote: > > > With all that said, > > > > +1 from Espressif. > > > > The following devices were tested using the internal CI with all > > available defconfigs. > > > > - esp32_devkitc > > - esp32_ethernet_kit > > - esp32_lyrat > > - esp32_pico_kit > > - esp32_wrover_kit > > - esp32c3_generic > > - esp32c6_devkitc > > - esp32c6_devkitm > > - esp32h2_devkit > > - esp32s2_saola > > - esp32s3_devkit > > - esp32s3_korvo_2 > > - esp32s3_lcd_ev > > > > Compilers used: > > > > - riscv-none-elf-gcc (xPack GNU RISC-V Embedded GCC x86_64) 13.2.0 > > - xtensa-esp32-elf-gcc (crosstool-NG esp-12.2.0_20230208) 12.2.0 > > - xtensa-esp32s2-elf-gcc (crosstool-NG esp-12.2.0_20230208) 12.2.0 > > - xtensa-esp32s3-elf-gcc (crosstool-NG esp-12.2.0_20230208) 12.2.0 > > > > > > Best regards, > > Filipe > > > > ________________________________ > > From: Alin Jerpelea <jerpe...@gmail.com> > > Sent: Friday, January 3, 2025 12:30 PM > > To: dev@nuttx.apache.org <dev@nuttx.apache.org> > > Subject: Re: [VOTE] Apache NuttX 12.8.0 RC0 release > > > > [External: This email originated outside Espressif] > > > > Hi Tiago, > > > > Nxstyle is not a problem unless we have compilation issues. > > We had various nxstyle errors before and we fixed them as we touched the > > files. > > > > @all do you think that we should stop the release for nxstyle errors? > > > > Do you have issues your boards? > > > > Best regards > > Alin > > > > On Fri, 3 Jan 2025, 13:01 Tiago Medicci Serrano, < > tiago.medi...@gmail.com> > > wrote: > > > > > Hi Alin, > > > > > > You are right about the PR, but the last e-mail from Filipe is an > issue: > > > style check failed to check some files from various architectures. > Those > > > files were (probably) added before we had the style check tool and when > > you > > > added the SPDX identifier they were listed to be checked by the tool. > > > > > > You can check with: > > > ``` > > > git --no-pager diff nuttx-12.7.0 --name-only | xargs > > > ../nuttx/tools/checkpatch.sh -f > > > ``` > > > > > > I attached the output for it (it's a long list!). We can fix the ones > > > related to Espressif, but we need help fixing the files from other > > vendors. > > > I'm curious about how our CI didn't get these errors too... > > > > > > Unfortunately, we can't release it as-is. So, *-1 (binding)* for me. > > > > > > Best regards > > > > > > Em sex., 3 de jan. de 2025 às 02:28, Alin Jerpelea <jerpe...@gmail.com > > > > > escreveu: > > > > > >> Hi Felipe, > > >> > > >> the suggested PR is a feature not a bugfix. Usually only fixes are > > >> backported. > > >> > > >> There are some concerns we should think about: > > >> Adding a feature during the release will restart the release process > and > > >> delay the release. > > >> Adding features on demand during the vote may trigger a new feature > > >> request > > >> which may delay the release again (the process may repeat many times > > since > > >> we did it once) > > >> > > >> My proposal is to continue the release as it is and add add the > proposed > > >> feature in the next release. > > >> > > >> Best Regards > > >> Alin > > >> > > >> > > >> On Thu, 2 Jan 2025, 14:00 Filipe Cavalcanti, > > >> <filipe.cavalca...@espressif.com.invalid> wrote: > > >> > > >> > -1 > > >> > > > >> > > > >> > We are having issues testing ESP32C3 on this tag, due to a missing > > fix. > > >> > > > >> > Can we backport this PR? https://github.com/apache/nuttx/pull/15321 > > >> > [ > > >> > > > >> > > > https://opengraph.githubassets.com/81ba79de2d577149394fe3e933d244bb47903f11701e3954febfdae67530b95c/apache/nuttx/pull/15321 > > >> > ]<https://github.com/apache/nuttx/pull/15321> > > >> > Improve QEMU support on ESP32S3|C3 by fdcavalcanti · Pull Request > > >> #15321 · > > >> > apache/nuttx<https://github.com/apache/nuttx/pull/15321> > > >> > Summary This PR contains 3 commits that increase overall support for > > >> QEMU. > > >> > Add --fill-flash-size option to Espressif build system, which fills > > the > > >> > binary with 0xff depending on flash size and if ... > > >> > github.com > > >> > > > >> > > > >> > > > >> > > > >> > ________________________________ > > >> > From: Roberto Bucher <bubu.buc...@gmail.com> > > >> > Sent: Tuesday, December 31, 2024 6:19 AM > > >> > To: dev@nuttx.apache.org <dev@nuttx.apache.org> > > >> > Subject: Re: [VOTE] Apache NuttX 12.8.0 RC0 release > > >> > > > >> > [You don't often get email from bubu.buc...@gmail.com. Learn why > this > > >> is > > >> > important at https://aka.ms/LearnAboutSenderIdentification ] > > >> > > > >> > [External: This email originated outside Espressif] > > >> > > > >> > + 1 > > >> > > > >> > for stm32f7 (NUCLEO-F746ZG) and stm32h7 (NUCLEO-H743ZI2 and > > >> > NUCLEO-H745ZI-Q) > > >> > > > >> > Tested also on code automatic generated for the NUCLEO-F746Zg board > (1 > > >> > PWM+1 encoder + plot on Plotjuggler via UDP) > > >> > > > >> > *Test results:* > > >> > > > >> > bucher@debian:~/ToDo/NUTTX_release_test$ arm-none-eabi-gcc -v > > >> > Using built-in specs. > > >> > COLLECT_GCC=arm-none-eabi-gcc > > >> > COLLECT_LTO_WRAPPER=/usr/lib/gcc/arm-none-eabi/13.3.1/lto-wrapper > > >> > Target: arm-none-eabi > > >> > Configured with: ../configure --build=x86_64-linux-gnu --prefix=/usr > > >> > --includedir='/usr/lib/include' --mandir='/usr/lib/share/man' > > >> > --infodir='/usr/lib/share/info' --sysconfdir=/etc > --localstatedir=/var > > >> > --disable-option-checking --disable-silent-rules > > >> > --libdir='/usr/lib/lib/x86_64-linux-gnu' > > >> > --libexecdir='/usr/lib/lib/x86_64-linux-gnu' > --disable-maintainer-mode > > >> > --disable-dependency-tracking --mandir=/usr/share/man > > >> > --enable-languages=c,c++,lto --enable-multilib > --disable-decimal-float > > >> > --disable-libffi --disable-libgomp --disable-libmudflap > > >> > --disable-libquadmath --disable-libssp --disable-libstdcxx-pch > > >> > --disable-nls --disable-shared --disable-threads --enable-tls > > >> > --build=x86_64-linux-gnu --target=arm-none-eabi --with-system-zlib > > >> > --with-gnu-as --with-gnu-ld --with-pkgversion=15:13.3.rel1-1 > > >> > --without-included-gettext --prefix=/usr/lib > > >> > --infodir=/usr/share/doc/gcc-arm-none-eabi/info > > >> > --htmldir=/usr/share/doc/gcc-arm-none-eabi/html > > >> > --pdfdir=/usr/share/doc/gcc-arm-none-eabi/pdf --bindir=/usr/bin > > >> > --libexecdir=/usr/lib --libdir=/usr/lib --disable-libstdc++-v3 > > >> > --host=x86_64-linux-gnu --with-headers=no --without-newlib > > >> > --with-multilib-list=rmprofile,aprofile ASFLAGS= ASFLAGS_FOR_BUILD= > > >> > CFLAGS='-g -O2 -Werror=implicit-function-declaration > > >> > > > -ffile-prefix-map=/build/reproducible-path/gcc-arm-none-eabi-13.3.rel1=. > > >> > -fstack-protector-strong -fstack-clash-protection -fcf-protection' > > >> > 'CFLAGS_FOR_BUILD=-g -O2 -Werror=implicit-function-declaration > > >> > > > -ffile-prefix-map=/build/reproducible-path/gcc-arm-none-eabi-13.3.rel1=. > > >> > -fstack-protector-strong -fstack-clash-protection -fcf-protection' > > >> > CPPFLAGS='-Wdate-time -D_FORTIFY_SOURCE=2' > > >> > 'CPPFLAGS_FOR_BUILD=-Wdate-time -D_FORTIFY_SOURCE=2' CXXFLAGS='-g > -O2 > > >> > > > -ffile-prefix-map=/build/reproducible-path/gcc-arm-none-eabi-13.3.rel1=. > > >> > -fstack-protector-strong -fstack-clash-protection -fcf-protection' > > >> > 'CXXFLAGS_FOR_BUILD=-g -O2 > > >> > > > -ffile-prefix-map=/build/reproducible-path/gcc-arm-none-eabi-13.3.rel1=. > > >> > -fstack-protector-strong -fstack-clash-protection -fcf-protection' > > >> > DFLAGS=-frelease DFLAGS_FOR_BUILD=-frelease FCFLAGS='-g -O2 > > >> > > > -ffile-prefix-map=/build/reproducible-path/gcc-arm-none-eabi-13.3.rel1=. > > >> > -fstack-protector-strong -fstack-clash-protection -fcf-protection' > > >> > 'FCFLAGS_FOR_BUILD=-g -O2 > > >> > > > -ffile-prefix-map=/build/reproducible-path/gcc-arm-none-eabi-13.3.rel1=. > > >> > -fstack-protector-strong -fstack-clash-protection -fcf-protection' > > >> > FFLAGS='-g -O2 > > >> > > > -ffile-prefix-map=/build/reproducible-path/gcc-arm-none-eabi-13.3.rel1=. > > >> > -fstack-protector-strong -fstack-clash-protection -fcf-protection' > > >> > 'FFLAGS_FOR_BUILD=-g -O2 > > >> > > > -ffile-prefix-map=/build/reproducible-path/gcc-arm-none-eabi-13.3.rel1=. > > >> > -fstack-protector-strong -fstack-clash-protection -fcf-protection' > > >> > LDFLAGS=-Wl,-z,relro LDFLAGS_FOR_BUILD=-Wl,-z,relro OBJCFLAGS='-g > -O2 > > >> > > > -ffile-prefix-map=/build/reproducible-path/gcc-arm-none-eabi-13.3.rel1=. > > >> > -fstack-protector-strong -fstack-clash-protection -fcf-protection' > > >> > 'OBJCFLAGS_FOR_BUILD=-g -O2 > > >> > > > -ffile-prefix-map=/build/reproducible-path/gcc-arm-none-eabi-13.3.rel1=. > > >> > -fstack-protector-strong -fstack-clash-protection -fcf-protection' > > >> > OBJCXXFLAGS='-g -O2 > > >> > > > -ffile-prefix-map=/build/reproducible-path/gcc-arm-none-eabi-13.3.rel1=. > > >> > -fstack-protector-strong -fstack-clash-protection -fcf-protection' > > >> > 'OBJCXXFLAGS_FOR_BUILD=-g -O2 > > >> > > > -ffile-prefix-map=/build/reproducible-path/gcc-arm-none-eabi-13.3.rel1=. > > >> > -fstack-protector-strong -fstack-clash-protection -fcf-protection' > > >> > INHIBIT_LIBC_CFLAGS=-DUSE_TM_CLONE_REGISTRY=0 > > >> > AR_FOR_TARGET=arm-none-eabi-ar AS_FOR_TARGET=arm-none-eabi-as > > >> > LD_FOR_TARGET=arm-none-eabi-ld NM_FOR_TARGET=arm-none-eabi-nm > > >> > OBJDUMP_FOR_TARGET=arm-none-eabi-objdump > > >> > RANLIB_FOR_TARGET=arm-none-eabi-ranlib > > >> > READELF_FOR_TARGET=arm-none-eabi-readelf > > >> > STRIP_FOR_TARGET=arm-none-eabi-strip SED=/bin/sed SHELL=/bin/sh > > >> > BASH=/bin/bash CONFIG_SHELL=/bin/bash > > >> > Thread model: single > > >> > Supported LTO compression algorithms: zlib > > >> > gcc version 13.3.1 20240614 (15:13.3.rel1-1) > > >> > > > >> > nucleo-h745zi:pysim_cm7 > > >> > ================ > > >> > > > >> > Memory region Used Size Region Size %age Used > > >> > itcm: 0 B 64 KB 0.00% > > >> > flash: 335032 B 1 MB 31.95% > > >> > dtcm1: 0 B 64 KB 0.00% > > >> > dtcm2: 0 B 64 KB 0.00% > > >> > sram: 42632 B 512 KB 8.13% > > >> > shmem: 0 B 32 KB 0.00% > > >> > sram4: 0 B 64 KB 0.00% > > >> > bbram: 0 B 4 KB 0.00% > > >> > > > >> > -rwxrwxr-x 1 bucher bucher 3720380 Dec 31 09:30 nuttx/nuttx > > >> > -rwxrwxr-x 1 bucher bucher 335032 Dec 31 09:30 nuttx/nuttx.bin > > >> > -rw-rw-r-- 1 bucher bucher 6416493 Dec 31 09:30 > > >> > nuttx/nuttx-export-12.8.0.tar.gz > > >> > -rw-rw-r-- 1 bucher bucher 942433 Dec 31 09:30 nuttx/nuttx.hex > > >> > -rw-rw-r-- 1 bucher bucher 47 Dec 31 09:30 nuttx/nuttx.manifest > > >> > -rw-rw-r-- 1 bucher bucher 2326813 Dec 31 09:30 nuttx/nuttx.map > > >> > > > >> > nsh> uname -a > > >> > NuttX 12.8.0 3bf704ad13 Dec 31 2024 09:30:09 arm nucleo-h745zi > > >> > nsh> free > > >> > total used free maxused maxfree nused > nfree > > >> name > > >> > 677240 19064 658176 19456 480112 58 3 > Umem > > >> > nsh> > > >> > > > >> > > > >> > > > ----------------------------------------------------------------------------------------------- > > >> > > > >> > nucleo-h743zi2:pysim > > >> > ============== > > >> > > > >> > Memory region Used Size Region Size %age Used > > >> > itcm: 0 B 64 KB 0.00% > > >> > flash: 334612 B 2 MB 15.96% > > >> > dtcm1: 0 B 64 KB 0.00% > > >> > dtcm2: 0 B 64 KB 0.00% > > >> > sram: 42632 B 512 KB 8.13% > > >> > sram1: 0 B 128 KB 0.00% > > >> > sram2: 0 B 128 KB 0.00% > > >> > sram3: 0 B 32 KB 0.00% > > >> > sram4: 0 B 64 KB 0.00% > > >> > bbram: 0 B 4 KB 0.00% > > >> > > > >> > rwxrwxr-x 1 bucher bucher 3712712 Dec 31 09:38 nuttx > > >> > -rwxrwxr-x 1 bucher bucher 334612 Dec 31 09:38 nuttx.bin > > >> > -rw-rw-r-- 1 bucher bucher 6408317 Dec 31 09:38 > > >> nuttx-export-12.8.0.tar.gz > > >> > -rw-rw-r-- 1 bucher bucher 941255 Dec 31 09:38 nuttx.hex > > >> > -rw-rw-r-- 1 bucher bucher 47 Dec 31 09:38 nuttx.manifest > > >> > -rw-rw-r-- 1 bucher bucher 2314704 Dec 31 09:38 nuttx.map > > >> > > > >> > NuttShell (NSH) NuttX-12.8.0 > > >> > nsh> uname -a > > >> > NuttX 12.8.0 3bf704ad13 Dec 31 2024 09:38:04 arm nucleo-h743zi2 > > >> > nsh> free > > >> > total used free maxused maxfree nused > nfree > > >> name > > >> > 972152 19080 953072 19472 480112 60 4 > Umem > > >> > nsh> > > >> > > > >> > > > >> > > > ----------------------------------------------------------------------------------------------- > > >> > > > >> > nucleo-f746zg:pysim > > >> > ============= > > >> > > > >> > Memory region Used Size Region Size %age Used > > >> > itcm: 0 B 1 MB 0.00% > > >> > flash: 321620 B 1 MB 30.67% > > >> > dtcm: 0 B 64 KB 0.00% > > >> > sram1: 42944 B 240 KB 17.47% > > >> > sram2: 0 B 16 KB 0.00% > > >> > CP: nuttx.bin > > >> > make[1]: Leaving directory > > '/home/bucher/ToDo/NUTTX_release_test/nuttx' > > >> > make[1]: Entering directory > > '/home/bucher/ToDo/NUTTX_release_test/nuttx' > > >> > make[1]: Leaving directory > > '/home/bucher/ToDo/NUTTX_release_test/nuttx' > > >> > -rwxrwxr-x 1 bucher bucher 488412 Dec 31 09:47 nuttx > > >> > -rwxrwxr-x 1 bucher bucher 321620 Dec 31 09:47 nuttx.bin > > >> > -rw-rw-r-- 1 bucher bucher 3592665 Dec 31 09:47 > > >> nuttx-export-12.8.0.tar.gz > > >> > -rw-rw-r-- 1 bucher bucher 37 Dec 31 09:47 nuttx.manifest > > >> > -rw-rw-r-- 1 bucher bucher 1709042 Dec 31 09:47 nuttx.map > > >> > bucher@debian:~/ToDo/NUTTX_release_test$ > > >> > > > >> > nsh> uname -a > > >> > NuttX 12.8.0 3bf704ad13 Dec 31 2024 09:48:47 arm nucleo-f746zg > > >> > nsh> free > > >> > total used free maxused maxfree nused > nfree > > >> name > > >> > 217152 14880 202272 15256 200264 58 3 > Umem > > >> > nsh> > > >> > > > >> > > > >> > > > >> > > > >> > > > > > >
