No rush at all, thanks On Mon, Oct 9, 2023 at 8:23 PM Xiang Xiao <xiaoxiang781...@gmail.com> wrote:
> Let' me find some time to write a test, please wait for a moment. > > On Tue, Oct 10, 2023 at 2:53 AM Daniel Appiagyei > <daniel.appiag...@braincorp.com.invalid> wrote: > > > Good solution. > > I'm not too knowledgeable about makefiles, but if you could set that part > > up then I can do the work to make the files compatible? > > > > On Sun, Oct 8, 2023 at 10:44 PM Xiang Xiao <xiaoxiang781...@gmail.com> > > wrote: > > > > > We can add a simple test like this: > > > > > > 1. Create a context target in Makefile to generate a .cxx file which > > > list and include all header files in nuttx/include > > > 2. Add the generated file to CXXSRCS > > > > > > If we just want to ensure the public nuttx header files are compatible > > with > > > c++ syntax. > > > > > > On Mon, Oct 9, 2023 at 9:47 AM Daniel Appiagyei > > > <daniel.appiag...@braincorp.com.invalid> wrote: > > > > > > > Late follow up, sorry > > > > > > > > Thanks guys, I do understand that only headers need to be compatible, > > > > however, the GCC check I mentioned above does not discriminate > between > > > > headers and source files. If we don't have some sort of automated > check > > > for > > > > C++ compatibility, then we will run into issues in the future like I > > > > mentioned above. The nuttx style guide mentions that all C code must > be > > > C89 > > > > compliant. As long as C++ compatibility doesn't interfere with that > > > > standard then we won't be losing much. > > > > Are there any other ideas on how to automatically enforce headers > being > > > c++ > > > > comaptible? > > > > Best, > > > > Daniel > > > > > > > > On Sun, Sep 17, 2023 at 12:56 PM Petro Karashchenko < > > > > petro.karashche...@gmail.com> wrote: > > > > > > > > > Since C++ most likely will never be used in the kernel I see that > > > > > compatibility border should stay in the "include" folder in nuttx > > repo. > > > > The > > > > > nuttx-apps headers should be C++ compatible as we can mix things at > > > > > application level. > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > *Daniel Appiagyei | Embedded Software Engineer *Email: > > > > daniel.appiag...@braincorp.com > > > > <bog...@braincorporation.com>*Brain* > > > > * Corp™ *10182 Telesis Ct, Suite 100 > > > > San Diego, CA 92121 > > > > > > > > (858)-689-7600 > > > > www.braincorp.com > > > > > > > > > > > > > -- > > > > > > *Daniel Appiagyei | Embedded Software Engineer *Email: > > daniel.appiag...@braincorp.com > > <bog...@braincorporation.com>*Brain* > > * Corp™ *10182 Telesis Ct, Suite 100 > > San Diego, CA 92121 > > > > (858)-689-7600 > > www.braincorp.com > > >
