Emm, I confirmed that one of my test platform (esp32c3), its cdcacm driver 
implement the uart_ops, but rp2040 seems not.


CLE should works since it will override the content from driver ECHO if over 
serial driver, but readline shouldn't echo input.


I'll test more to confirm it.

________________________________
发件人: Gregory Nutt <spudan...@gmail.com>
发送时间: 2023年3月10日 23:22:45
收件人: dev@nuttx.apache.org
主题: Re: 答复: [External Mail]Re: [Breaking change] Echo character by serial driver

[外部邮件] 此邮件来源于小米公司外部,请谨慎处理。若对邮件安全性存疑,请将邮件转发给mi...@xiaomi.com进行反馈

> nsh over usb works with readline/cle now.
>
>
> In face, isconsole in current implementation is more like a very tiny `line 
> driver` inside the serial driver.

That is very interesting.  The serial driver (drivers/usbdev/cdcacm.c).
Does not include any of your change. It does not use serial.c .  It has
its own serial interface and its own TERMIOS implementation that does
not use your changes.

So I would expect serial.c to be better behaved without the ECHO as well.

#/******本邮件及其附件含有小米公司的保密信息,仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用(包括但不限于全部或部分地泄露、复制、或散发)本邮件中的信息。如果您错收了本邮件,请您立即电话或邮件通知发件人并删除本邮件!
 This e-mail and its attachments contain confidential information from XIAOMI, 
which is intended only for the person or entity whose address is listed above. 
Any use of the information contained herein in any way (including, but not 
limited to, total or partial disclosure, reproduction, or dissemination) by 
persons other than the intended recipient(s) is prohibited. If you receive this 
e-mail in error, please notify the sender by phone or email immediately and 
delete it!******/#

Reply via email to