On Tue, Nov 15, 2022 at 2:25 PM Tim Hardisty <t...@jti.uk.com.invalid> wrote:
> As subject really. My (first real) PR failed some checks due to an unused > variable. An easy fix, but I wanted to wait for any other feedback before > resubmitting....but not much point waiting if the fail will mean no one > reviews it lol. > > What's the process? PRs are not ignored. Generally you can just fix the problem and push to the branch. For certain test failures, sometimes we even ignore the failures and merge, such as if the PR fixes a typo or something and there's a NXSTYLE violation elsewhere in the file that has been there for a long time and would be nontrivial to fix and totally outside the scope of the PR. For important test failures, like compiler warnings or whatever, they should be fixed. You could comment on the PR that you know about the fail and would like other feedback in the meantime. Also feel free to request reviews on Git Hub from people who generally work on those areas. Hope this helps Nathan
