On Mon, Oct 18, 2021 at 4:57 AM Gregory Nutt wrote: > > Wow, that change has been in the Makefile for 20 years. > > Here is the original bugfix: > https://github.com/chexum/genromfs/commit/6d1b1e46bb7dbc25ca521c5dfcdc37d17dca8615 > > The bug was: > > -mkdir -p $(PREFIX)$(mandir) > +mkdir -p $(PREFIX)$(mandir)/man8 > install -m 644 genromfs.8 $(PREFIX)$(mandir)/man8/ > > Which installed the manpage in a regular file called man8 (the use of > bindir instead of mandir was also a bug it should have done nothing). > > And this one makes the code look like it does today: > https://github.com/chexum/genromfs/commit/427b121e23cd21d9b9ddb6caee3eb1064369358d > > Which looks wrong to me: Why does the change use bindir? Must be some > other issue that I can't see???
Probably a "fix" for bad install by 0.5 :-) https://github.com/chexum/genromfs/blob/4fdb9d00df13dfe52c28e8af058d38ce8bea89a1/Makefile install-man: mkdir -p $(PREFIX)/$(bindir) install -m 644 genromfs.8 $(PREFIX)/$(bindir)/man8 I would keep that file instead removing anything from $envvar / $clivar / usr as root, this is part of base OS, messing with /usr is wrong, this place is sacred, /usr/local is for local packages :-) Also prefix and PREFIX can be provided as command line and environment parameter so its not a constant location, is user controlled, and may differ between installations :-) -- CeDeROM, SQ7MHZ, http://www.tomek.cedro.info
