Hi,
> I think this is a good idea, case they are really similar and you don't need to use tons of #ifdef. I think few of the #ifdefs would be used in pre processor definition section as It would be great to let predefined displays resolutions but other than that there should not be many of them. I will get into this perhaps later this week or during the next, firstly I want to figure out what went wrong with Tickless Mode for iMXRT (desrcibed here https://github.com/apache/ incubator-nuttx/issues/4442). Best regards, Michal Lenc ---------- Původní e-mail ---------- Od: Alan Carvalho de Assis <acas...@gmail.com> Komu: dev@nuttx.apache.org Datum: 30. 8. 2021 15:22:21 Předmět: Re: Possibility of merging few lcd drivers into one file "Hi Michael, I think this is a good idea, case they are really similar and you don't need to use tons of #ifdef. Other driver that needs some care is the OLED SSD1106/SSD1306, there are many entries in the menuconfig for the same driver. It is using some specific manufacturer name instead of the IC controller. BR, Alan On 8/30/21, Michal Lenc <michall...@seznam.cz> wrote: > > Hi all, > > > > > I was taking a look into the current state of files for LCD drivers > (drivers/lcd/) and I am wondering about your opinion about this. Is there > any particulal reason not to merge few of those drivers into one file? I am > > talking mostly about merging files st7735.c, st7789.c and st7796.c (not > merged into mainline yet, just in my repo) into file st77xx.c (and do the > same with header files). It still could be configurable in menuconfig > separately as ST7735 or ST7789, but source codes would be in one file. It > should not be that hard to change this as st7789.c and st7796 are mostly > copies of st7735.c. Perhaps drivers for ST7565 and ST7567 could be also > merged into ST75XX, but that would take more job as the source codes seems > to be different. Thanks > > > Best regards, > Michal Lenc "
