> Abdelatif, let me know if you want me to prepare the PR. If licensing is > taken care of, I can simply place Apache header and submit it myself, right?
I did prepare the PR, however testing with latest master I found out that fcntl isn't working on socket descriptors.. I'm suspecting https://github.com/apache/incubator-nuttx/pull/2899 & the follow up https://github.com/apache/incubator-nuttx/pull/3045 The little debugging I did showed that fs_getfilep is returning a bad file structure in case of a socket descriptor. I still didn't debug it any further. On Sun, Mar 28, 2021 at 11:33 PM Matias N. <mat...@imap.cc> wrote: > > Abdelatif, let me know if you want me to prepare the PR. If licensing is > taken care of, I can simply > place Apache header and submit it myself, right? > > Best, > Matias > > On Thu, Mar 25, 2021, at 19:05, Abdelatif Guettouche wrote: > > Espressif has already signed an SGA, licensing shouldn't be an issue. > > That said, I can submit it later if you guys want. > > One question: where do we put the library? > > A new "mqtt" folder? > > > > On Thu, Mar 25, 2021 at 10:59 PM Alan Carvalho de Assis > > <acas...@gmail.com <mailto:acassis%40gmail.com>> wrote: > > > > > > On 3/25/21, Matias N. <mat...@imap.cc <mailto:matias%40imap.cc>> wrote: > > > > > > > > > > > > On Thu, Mar 25, 2021, at 15:21, Alan Carvalho de Assis wrote: > > > >> Hi Matias, > > > >> > > > >> On 3/25/21, Matias N. <mat...@imap.cc <mailto:matias%40imap.cc> > > > >> <mailto:matias%40imap.cc>> wrote: > > > >> > > > > >> > > > > >> > On Thu, Mar 25, 2021, at 15:02, Abdelatif Guettouche wrote: > > > >> >> Someone was asking the other day on Linkedin, so I pushed this: > > > >> >> https://github.com/Ouss4/MQTTC_NuttX > > > >> > > > > >> > Great, thanks! I see the wrapper app is quite simple. Could we submit > > > >> > it > > > >> > to nuttx apps repo? > > > >> > > > > >> > > > >> Yes, please! > > > > > > > > The copyright header is from Espressif so I guess it would be best if > > > > someone at Espressif can submit it > > > > (not sure if it would require a SGA). > > > > > > > > > > It is not a code from IDF, it was Abdelatif whom added it :-) > > > > > > But you are right, maybe it is better if we submit it because there is > > > an Espressif copyright on it. > > > > > > BR, > > > > > > Alan > >
